Conversation
1998LJ
force-pushed
the
fix/runpath-auditwheel-ld-library-path
branch
from
September 27, 2026 12:11
b0a8069 to
405980f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 96.07% 96.22% +0.15%
==========================================
Files 23 23
Lines 2036 2038 +2
Branches 388 389 +1
==========================================
+ Hits 1956 1961 +5
+ Misses 46 44 -2
+ Partials 34 33 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #737.
AUDITWHEEL_LD_LIBRARY_PATHcurrently shares the same internal search-path bucket asLD_LIBRARY_PATH, which places both after an ELF'sDT_RUNPATH.This separates the auditwheel-specific environment path from the standard
LD_LIBRARY_PATHand gives it the lower-risk precedence discussed in #737:RPATH > AUDITWHEEL_LD_LIBRARY_PATH > RUNPATH > LD_LIBRARY_PATHThe existing precedence of
RUNPATHover the standardLD_LIBRARY_PATHis intentionally preserved.The change also keeps compatibility with callers that provide the existing
ldpathsdictionary shape without the new auditwheel-specific entry.Tests cover:
RUNPATHcontinuing to overrideLD_LIBRARY_PATH;AUDITWHEEL_LD_LIBRARY_PATHoverridingRUNPATH;root != "/"behavior;ldpathsdictionaries.Validation:
pytest tests/unit/test_lddtree.pypytest tests/unitnox -s lintgit diff --check