chore: move blacklisted symbol test to a bundled wheel - #707
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 95.91% 96.01% +0.10%
==========================================
Files 23 23
Lines 1981 1981
Branches 374 374
==========================================
+ Hits 1900 1902 +2
+ Misses 46 45 -1
+ Partials 35 34 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the zlib blacklisted-symbol integration test from an on-the-fly built extension (tests/integration/testzlib/*) into a prebuilt, bundled wheel and rehomes the test logic into test_bundled_wheels.py, so the test remains available when Python 3.10 is dropped.
Changes:
- Remove the in-repo
testzlibextension source and build configuration used to generate the wheel during tests. - Remove the container-based
test_zlib_blacklistintegration test fromtest_manylinux.py. - Add a new bundled-wheel based blacklist-symbol test to
tests/integration/test_bundled_wheels.pyand commit the prebuilt wheel artifact.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/testzlib/testzlib.c | Removes the C extension source previously compiled during integration tests. |
| tests/integration/testzlib/setup.py | Removes setuptools build script for the testzlib test extension. |
| tests/integration/testzlib/pyproject.toml | Removes build-system metadata for building the testzlib wheel. |
| tests/integration/test_manylinux.py | Removes the container-based zlib blacklist integration test. |
| tests/integration/test_bundled_wheels.py | Adds a new test that uses a bundled testzlib wheel to validate blacklist detection/reporting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked from #703 to ensure the test will be kept when dropping Python 3.10
Pre-build wheel used for blacklisted symbol test and move the test to
test_bundled_wheels.py