Skip to content

fix(tests): manylinux images moved to gcc-toolset-15 - #664

Draft
mayeut wants to merge 2 commits into
pypa:mainfrom
mayeut:manylinux-update
Draft

mayeut wants to merge 2 commits into
pypa:mainfrom
mayeut:manylinux-update

Conversation

@mayeut

@mayeut mayeut commented Jan 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jan 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (80ebc79) to head (74bd68c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          23       23           
  Lines        2036     2036           
  Branches      388      388           
=======================================
  Hits         1956     1956           
  Misses         46       46           
  Partials       34       34           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mayeut
mayeut marked this pull request as draft January 3, 2026 13:24
@mayeut

mayeut commented Jan 3, 2026

Copy link
Copy Markdown
Member Author

the new gcc-toolset will be reverted shortly in manylinux: pypa/manylinux#1900
just one analysis done on tests/integration/test_manylinux.py::TestManylinux::test_rpath[manylinux_2_28-rpath]:
segfaults when calling init on a grafted library.

LD_DEBUG=libs python '-c' 'from testrpath import testrpath; print(testrpath.func())'
...
       470:	calling init: /opt/python/cp310-cp310/lib/python3.10/site-packages/testrpath/../testrpath.libs/libb-1c566650.so
       470:	
Segmentation fault (core dumped)

The assembly for this simple lib is the same between gcc-14 & gcc-15, the difference appears once linked as a shared library (the disassembly for the shared object is also the same for both versions except for offsets).

@mayeut

mayeut commented Jan 4, 2026

Copy link
Copy Markdown
Member Author

The issue with patchelf 0.17.2 is likely the same as NixOS/patchelf#568
There's no released version of patchelf with NixOS/patchelf#544
It might be time to revisit #174
repairwheel patcher works on that test case
lief-patchelf patcher from LIEF works on that test case as well

@mayeut
mayeut force-pushed the manylinux-update branch from 56b4f1d to d99a83a Compare April 26, 2026 07:08
@mayeut
mayeut force-pushed the manylinux-update branch 4 times, most recently from 3aa4fea to eae27ac Compare June 6, 2026 14:29
@mayeut
mayeut force-pushed the manylinux-update branch from c4819e6 to 3279dcb Compare June 27, 2026 06:54
@mayeut
mayeut force-pushed the manylinux-update branch 4 times, most recently from 042cf59 to 569d605 Compare July 3, 2026 04:06
@mayeut
mayeut force-pushed the manylinux-update branch from 569d605 to e79d220 Compare July 4, 2026 08:05
@mayeut
mayeut force-pushed the manylinux-update branch 4 times, most recently from bdc0ca2 to b37e586 Compare July 11, 2026 06:58
@mayeut
mayeut force-pushed the manylinux-update branch from b37e586 to 68db83a Compare July 11, 2026 09:09
@mayeut
mayeut force-pushed the manylinux-update branch from 68db83a to f7cebcd Compare July 20, 2026 05:12
@mayeut
mayeut force-pushed the manylinux-update branch from f7cebcd to 9d6ced9 Compare August 2, 2026 07:03
@mayeut
mayeut force-pushed the manylinux-update branch 2 times, most recently from 74bd68c to 56ed23e Compare August 17, 2026 05:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant