Skip to content

Add pygame test script for set timer#4

Open
e-dong wants to merge 6 commits into
pygame-web:mainfrom
e-dong:test-set-timer
Open

Add pygame test script for set timer#4
e-dong wants to merge 6 commits into
pygame-web:mainfrom
e-dong:test-set-timer

Conversation

@e-dong

@e-dong e-dong commented Feb 22, 2024

Copy link
Copy Markdown

No description provided.

@e-dong e-dong marked this pull request as draft February 22, 2024 11:30
@e-dong

e-dong commented Feb 22, 2024

Copy link
Copy Markdown
Author

@pmp-p

TO DOs

  • test loop handling for number of repeated events
  • test event as an object type
  • test timer cancel
  • test timer repeated call

@pmp-p pmp-p left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing against pygame-web/platform_wasm#1

@pmp-p

pmp-p commented Feb 22, 2024

Copy link
Copy Markdown
Member

just missing a call to pygame.init()

@e-dong

e-dong commented Feb 22, 2024

Copy link
Copy Markdown
Author

just missing a call to pygame.init()

and updating testsuite.py I assume

@e-dong e-dong marked this pull request as ready for review February 22, 2024 13:25
@e-dong

e-dong commented Feb 22, 2024

Copy link
Copy Markdown
Author

@pmp-p Do the showcase scripts target pygbag stable or git?

@pmp-p

pmp-p commented Feb 23, 2024

Copy link
Copy Markdown
Member

git, i should have made a 0.9 release already but i'm waiting for that thread stuff + test. Because it is actually the most complex tests to have and 0.9-1.0 cycle will be all about testsuites.

@e-dong

e-dong commented Feb 23, 2024

Copy link
Copy Markdown
Author

git, i should have made a 0.9 release already but i'm waiting for that thread stuff + test. Because it is actually the most complex tests to have and 0.9-1.0 cycle will be all about testsuites.

Ooh gotcha, thanks I will update my tests, since I was using stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants