Skip to content

Put keynote slides #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yychen merged 6 commits into from
Jan 11, 2021
Merged

Put keynote slides #946

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93060c7
Optimized structure
Maliaotw Sep 20, 2020
e78e82f
Put keynote slides
Maliaotw Sep 20, 2020
2c44c6a
Merge remote-tracking branch 'origin/dev_issue944_keynote_slides' int…
Maliaotw Sep 20, 2020
89a5396
add slides tab
Maliaotw Sep 20, 2020
acded63
Merge remote-tracking branch 'upstream/master' into dev_issue944_keyn…
Maliaotw Dec 5, 2020
deb112e
Update the display of slide
Maliaotw Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/static/pycontw-2020/assets/keynotes/mariatta-wijaya.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@
"twitter": "https://twitter.com/mariatta",
"github": "https://github.com/mariatta"
},
"slido": "https://app.sli.do/event/vppisnh8"
"slido": "https://app.sli.do/event/vppisnh8",
"slides": "https://speakerdeck.com/mariatta/oops-i-became-an-open-source-maintainer"
}
114 changes: 60 additions & 54 deletions src/templates/pycontw-2020/contents/_default/conference/keynotes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

{% block content %}

<!--
<!--
<div class="breadcrumbs">
<ol>
<li><a href="{% url 'index' %}">{% trans 'Home' %}</a></li>
Expand All @@ -20,66 +20,72 @@
</div>
-->

<section class="pill-title">
<h1>{% trans 'Keynotes' %}</h1>
</section>
<section class="pill-title">
<h1>{% trans 'Keynotes' %}</h1>
</section>

{% get_keynote_events as keynote_events %}
{% get_keynote_events as keynote_events %}

{% for event in keynote_events %}
{% for event in keynote_events %}

{% with data=event.get_static_data_for_locale %}
{% with data=event.get_static_data_for_locale %}

<article class="media" id="keynote-speaker-{{ event.slug }}">
<header>
<figure>
<img src="{% static data.photo %}">
<figcaption>{{ data.speaker.name }}</figcaption>
</figure>
<h2 class="title">{{ data.session.title }}</h2>
</header>
<div class="tabbing" data-controller="tabbing">
<ul class="tabs">
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Biography' %}
</li>
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Speech' %}
</li>
{% if data.slido %}
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Slido' %}
</li>
{% endif %}
</ul>
<div>
<article data-target="tabbing.pane">
<h3 class="tab-title">{% trans 'Biography' %}</h3>
{{ data.speaker.bio|linebreaks }}
<div class="social">
{% for key, url in data.social.items %}
{% if url %}
<a href="{{ url }}" target="_blank" rel="noopener"><span class="fa fa-{{ key }}"></span></a>
{% endif %}
{% endfor %}
<article class="media" id="keynote-speaker-{{ event.slug }}">
<header>
<figure>
<img src="{% static data.photo %}">
<figcaption>{{ data.speaker.name }}</figcaption>
</figure>
<h2 class="title">{{ data.session.title }}</h2>
</header>
<div class="tabbing" data-controller="tabbing">
<ul class="tabs">
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Biography' %}
</li>
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Speech' %}
</li>
{% if data.slido %}
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Slido' %}
</li>
<li data-target="tabbing.tab" data-action="click->tabbing#activate">
{% trans 'Slides' %}
</li>
{% endif %}
</ul>
<div>
<article data-target="tabbing.pane">
<h3 class="tab-title">{% trans 'Biography' %}</h3>
{{ data.speaker.bio|linebreaks }}
<div class="social">
{% for key, url in data.social.items %}
{% if url %}
<a href="{{ url }}" target="_blank" rel="noopener"><span class="fa fa-{{ key }}"></span></a>
{% endif %}
{% endfor %}
</div>
</article>
<article data-target="tabbing.pane">
{% trans "To be announced" as placeholder_description %}
<h3 class="tab-title">{% trans 'Speech' %}</h3>
{{ data.session.description|default:placeholder_description|linebreaks }}
</article>
{% if data.slido %}
<article data-target="tabbing.pane">
<iframe class="slido" src="{{ data.slido }}"></iframe>
</article>
{% endif %}
<article data-target="tabbing.pane">
<a href="{{ data.slides }}">{{ data.slides }}</a>
</article>
Copy link
Copy Markdown
Member

@yychen yychen Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你這樣的話，第一是那一整個 tab 會很空，第二個是沒有投影片的人這邊就會點下去是空白的...

我在想，你有沒有辦法把他簡單的做，加在 "演講" 的那個 tab 的內容裡，但是變成很像 social links 那樣，如果有投影片，就放在最下面，例如

  {% if data.slides %}
	 <div class="slides">
		  Slides: <a href="{{ data.slides }}" target="_blank" rel="noopener">{{ data.slides}}</a>
	 </div>
  {% endif %}

</div>
</div>
</article>
<article data-target="tabbing.pane">
{% trans "To be announced" as placeholder_description %}
<h3 class="tab-title">{% trans 'Speech' %}</h3>
{{ data.session.description|default:placeholder_description|linebreaks }}
</article>
{% if data.slido %}
<article data-target="tabbing.pane">
<iframe class="slido" src="{{ data.slido }}"></iframe>
</article>
{% endif %}
</div>
</div>
</article>

{% endwith %}
{% endwith %}

{% endfor %}
{% endfor %}

{% endblock content %}