Improve Cloud and Unit test coverage #2419
Open
adehad wants to merge 3 commits into
Open
Conversation
studioj
previously approved these changes
May 1, 2026
adehad
force-pushed
the
enable-more-jira-cloud-tests
branch
from
bb3960b to
a366c56
Compare
Carry over the cloud-specific body changes from origin/enable-ci-again that pair with the @allow_on_cloud markers added in the previous commit: - IssueTests: sleeptime class attr (10s on cloud, 0 on server), used before search-after-mutate and around the rank ordering checks. Adds an unconditional time.sleep(1) inside the create_issues delete loop to let cloud catch up on bulk teardown. Switches the default search-fields probe to summary/description, which both server and cloud actually return without explicit field selection. - EpicTests.make_epic: omit the epic-name custom field when running against Jira Cloud CI - cloud auto-generates the field and rejects the explicit value. - FilterTests: pause one second after creating a filter on cloud, and skip the owner.name assertion on cloud where it returns empty. - DashboardTests: suppress JIRAError on tearDown so async cloud teardown failures don't poison the suite, and add one-second sleeps around dashboard gadget creation/update to give cloud time to materialise the gadget before the next call. - IssuePropertyTests: only assert the property list is empty after delete on server - cloud doesn't return an empty list synchronously.
The fix/jira-server-ci tox workflow filters with `tox -- -k test_unit` to run only the unit tests on PRs and on Windows/macOS jobs. Without the prefix none of the unit tests in test_exceptions.py, test_qsh.py or test_resilientsession.py match the keyword filter, so those tests have been silently skipped on every fix-branch CI run. Rename the affected pytest functions and unittest methods (and the matching tempfile-name variable in test_exceptions.py) to `test_unit_*` so the keyword filter actually hits them. The empty-dict-body assertion change from origin/enable-ci-again is deliberately not carried over - fix/jira-server-ci's commit ccbad3d aligned that test with actual production behaviour.
adehad
force-pushed
the
enable-more-jira-cloud-tests
branch
from
a366c56 to
9139cd8
Compare
studioj
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work from #2376