fix: parse_errors crashing on null values in errorMessages#2415
Open
star7js wants to merge 3 commits into
Open
fix: parse_errors crashing on null values in errorMessages#2415star7js wants to merge 3 commits into
star7js wants to merge 3 commits into
Conversation
When Jira returns {"errorMessages": [null]}, parse_errors() includes
the None in the list, causing parse_error_msg() to crash with
TypeError on ", ".join(errors) since None is not a string.
Filter out None values when extracting error messages from the
errorMessages array. Added test cases for null-only and mixed
null/string errorMessages.
Fixes pycontribs#2351
for more information, see https://pre-commit.ci
star7js
changed the title
Author
|
Quick triage bump — I don't have label perms here, so flagging for a maintainer to label whenever convenient. Closes #2351 with tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_errors()crashed withTypeError: sequence item 0: expected str instance, NoneType foundwhen Jira returns{"errorMessages": [null]}in the responseNonevalues when extracting from theerrorMessagesarrayAll existing tests continue to pass.
Closes #2351