Stop navigating next going up/down two pages

[aanthoonyy]

Work in progress for addressing regression found in #981 (comment)

[aanthoonyy]

Although everything appears to work as intended, I'm not confident about the code currently. I will spend some time revising my solution but for the time being I did want to get a fix going since it was my bug.

@colingeniet would you mind taking a look at this and making sure your issues are resolved.

[colingeniet]

Thanks a lot!

I tested with a mix of navigate and scrolling, and switching single page mode on/off.

It mostly works, but I managed hit #983, except on the vertical axis (so position was stuck at the very beginning of the document). I don't have a reliable way to cause it, but it happened twice (and I didn't manage to make it happen on the dev branch). Sorry for the bad news...

[aanthoonyy]

Yeah I saw it did that too but not every time

I wasn't aware of #981. I'll keep an eye on that pr and play around it more when I have time this week

[sebastinas]

I am somewhat missing what you are trying to fix. Could you please expand?

[aanthoonyy]

Sorry I'm figuring out grad school stuff rn, I'll give a proper explanation in a couple days

[aanthoonyy]

Sorry for leaving this hanging @sebastinas

I hope these screenshots clear it up

Before
Before toggling single page mode. Looking at page 12

After toggling single page mode. Looking at page 12 still

After toggling off single page mode. Looking at top of the page

After
Before toggling single page mode. Looking at page 12

After toggling single page mode. Looking at page 12 still

After toggling off single page mode. Looking at page 12 still, not page one

I kinda remember there being another bug, but the only bug I see is not being able to scroll after exiting normal mode. I didn't cause this I'm pretty sure as it exists on develop as well.

[aanthoonyy]

@sebastinas anything that you need cleared up here? We can close this pr as well if its not wanted/needed

[sebastinas]

My problem with this PR is that it looks like a workaround for an issue elsewhere. If some navigation command moves too far, we should fix this at the source.

[aanthoonyy]

I'll take a look. I assume the 'fix me' notes are for me?

[sebastinas]

See #1030

[aanthoonyy]

Ok, you can close this if he's got it

[sebastinas]

Thanks for looking into!