Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1035
Root cause: in
girara-gtk/completion.c,girara_isc_completion()starts with:This runs before the code that checks
argument->n == GIRARA_HIDEand actually destroys/hidessession->gtk.results.girara_isc_abort()(which Escape triggers viasc_abort → girara_sc_abort) callsgirara_isc_completion()withGIRARA_HIDEto close the popup — but once you've backspaced the input bar down to nothing (even the leading:is gone),input_length == 0and the function bails out immediately, so the hide logic never runs and the completion pane stays on screen.Fix: let a
GIRARA_HIDErequest through regardless of the current input bar contents:I took time to build (zathura + zathura-pdf-mupdf) and test this on my arch linux machine.
Let me know if anything needs to be edited before a merge.