fix: recognize openvzve container runtime#2801
Open
raman1236 wants to merge 1 commit into
Open
Conversation
Add 'openvzve' to the container runtime case statement in the Containers resolver. OpenVZ virtual environments set container=openvzve in /proc/1/environ, but this was not handled after the runtime detection was refactored in 4.8.0. Map 'openvzve' to the 'openvz' virtual fact for consistency with the existing OpenVZ resolver. Fixes puppetlabs#2784
Author
|
Friendly ping — this PR adds recognition for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recognize
openvzveas a valid container runtime in the Containers resolver.Problem
Since facter 4.8.0, running inside an OpenVZ virtual environment (
/proc/1/environcontainscontainer=openvzve) returns no virtual or hypervisor facts becauseopenvzveis not handled in theread_environcase statement.Fix
Add
when 'openvzve'case that maps tovm = 'openvz'for consistency with the existing OpenVZ resolver (lib/facter/resolvers/open_vz.rb).Fixes #2784