Skip to content

add support for Node20#53

Open
SturdyStubs wants to merge 1 commit intopterodactyl:masterfrom
SturdyStubs:master
Open

add support for Node20#53
SturdyStubs wants to merge 1 commit intopterodactyl:masterfrom
SturdyStubs:master

Conversation

@SturdyStubs
Copy link
Copy Markdown

Adding Node20 to dockerfile - fix for previously failed attempts to upgrade node. Will improve build times by 4x due to no more deprecation messages.

@WilliamVenner
Copy link
Copy Markdown
Member

I think both the current yolk and the yolk here after your changes are cooked in the year of our lord 2026.

Both branches gave me:

30.61 npm error Tracker "idealTree" already exists
30.61 npm error A complete log of this run can be found in: /root/.npm/_logs/2026-03-11T04_47_13_741Z-debug-0.log
------
Dockerfile:32
--------------------
  31 |
  32 | >>> RUN                  dpkg --add-architecture i386 \
  33 | >>>                      && apt update \
  34 | >>>                      && apt upgrade -y \
  35 | >>>                      && apt install -y lib32gcc-s1 lib32stdc++6 unzip curl iproute2 tzdata libgdiplus libsdl2-2.0-0:i386 \
  36 | >>>                      && curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh \
  37 | >>>                      && bash nodesource_setup.sh \
  38 | >>>                      && apt install -y nodejs \
  39 | >>>                      && mkdir /node_modules \
  40 | >>>                      && npm install --prefix / ws \
  41 | >>>                      && useradd -d /home/container -m container
  42 |
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c dpkg --add-architecture i386 \t\t\t&& apt update \t\t\t&& apt upgrade -y \t\t\t&& apt install -y lib32gcc-s1 lib32stdc++6 unzip curl iproute2 tzdata libgdiplus libsdl2-2.0-0:i386 \t\t\t&& curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh    \t\t\t&& bash nodesource_setup.sh \t\t\t&& apt install -y nodejs \t\t\t&& mkdir /node_modules \t\t\t&& npm install --prefix / ws \t\t\t&& useradd -d /home/container -m container" did not complete successfully: exit code: 1

Unsure of how this is building in CI. https://github.com/pterodactyl/yolks/actions/runs/22532622329/job/65274371175 it's not 😳

@SturdyStubs
Copy link
Copy Markdown
Author

I think both the current yolk and the yolk here after your changes are cooked in the year of our lord 2026.

Both branches gave me:


30.61 npm error Tracker "idealTree" already exists

30.61 npm error A complete log of this run can be found in: /root/.npm/_logs/2026-03-11T04_47_13_741Z-debug-0.log

------

Dockerfile:32

--------------------

  31 |

  32 | >>> RUN                  dpkg --add-architecture i386 \

  33 | >>>                      && apt update \

  34 | >>>                      && apt upgrade -y \

  35 | >>>                      && apt install -y lib32gcc-s1 lib32stdc++6 unzip curl iproute2 tzdata libgdiplus libsdl2-2.0-0:i386 \

  36 | >>>                      && curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh \

  37 | >>>                      && bash nodesource_setup.sh \

  38 | >>>                      && apt install -y nodejs \

  39 | >>>                      && mkdir /node_modules \

  40 | >>>                      && npm install --prefix / ws \

  41 | >>>                      && useradd -d /home/container -m container

  42 |

--------------------

ERROR: failed to build: failed to solve: process "/bin/sh -c dpkg --add-architecture i386 \t\t\t&& apt update \t\t\t&& apt upgrade -y \t\t\t&& apt install -y lib32gcc-s1 lib32stdc++6 unzip curl iproute2 tzdata libgdiplus libsdl2-2.0-0:i386 \t\t\t&& curl -fsSL https://deb.nodesource.com/setup_20.x -o nodesource_setup.sh    \t\t\t&& bash nodesource_setup.sh \t\t\t&& apt install -y nodejs \t\t\t&& mkdir /node_modules \t\t\t&& npm install --prefix / ws \t\t\t&& useradd -d /home/container -m container" did not complete successfully: exit code: 1

Unsure of how this is building in CI. https://github.com/pterodactyl/yolks/actions/runs/22532622329/job/65274371175 it's not 😳

I'll give it a test in a few days but when I made this PR it was working properly. I used this image as reference for my own image which uses this node 20 implementation to this day and works just fine.

A GitHub actions update could have broke something else in this image though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants