-
Notifications
You must be signed in to change notification settings - Fork 100
SSMP #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SSMP #484
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # SSMP - Silk Song Multiplayer | ||
|
|
||
| Pterodactyl Egg for hosting a Hollow Knight: Silksong multiplayer server. | ||
|
Comment on lines
+1
to
+3
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||||
| { | ||||||
|
||||||
| "_comment": "DO NOT EDIT: FILE GENERATED AUTOMATICALLY BY PTERODACTYL PANEL - PTERODACTYL.IO", | ||||||
| "meta": { | ||||||
| "version": "PTDL_v2", | ||||||
| "update_url": null | ||||||
| }, | ||||||
| "exported_at": "2025-05-03T00:00:00+00:00", | ||||||
| "name": "Silksong Multiplayer (SSMP)", | ||||||
| "author": "twangymoney@gmail.com", | ||||||
| "description": "Hollow Knight: Silksong Multiplayer Server", | ||||||
| "features": null, | ||||||
| "docker_images": { | ||||||
| ".NET 9": "ghcr.io/ptero-eggs/yolks:dotnet_9" | ||||||
|
||||||
| ".NET 9": "ghcr.io/ptero-eggs/yolks:dotnet_9" | |
| "Dotnet 9": "ghcr.io/ptero-eggs/yolks:dotnet_9" |
Copilot
AI
Mar 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installer script doesn’t validate that DOWNLOAD_URL was successfully resolved (it can be empty/"null" if the asset name changes, the API rate-limits, or the release has no matching asset), and it doesn’t fail fast on command errors. Add a check that DOWNLOAD_URL is non-empty and not null before downloading, and ensure the script exits on failures so installs don’t silently produce a broken server directory.
| "script": "#!/bin/ash\napk add --no-cache curl unzip jq\n\nmkdir -p /mnt/server\ncd /mnt/server\n\necho \"Getting latest release URL...\"\nDOWNLOAD_URL=$(curl -s https://api.github.com/repos/Extremelyd1/SSMP/releases/latest | jq -r '.assets[] | select(.name == \"SSMPServer-linux.zip\") | .browser_download_url')\n\necho \"Downloading from: ${DOWNLOAD_URL}\"\ncurl -L -o SSMPServer-linux.zip \"${DOWNLOAD_URL}\"\n\necho \"Extracting files...\"\nunzip -o SSMPServer-linux.zip\nrm SSMPServer-linux.zip\n\necho \"Listing files:\"\nls -la\n\necho \"Setting permissions...\"\nchmod +x SSMPServer\n\necho \"Installation complete!\"", | |
| "script": "#!/bin/ash\nset -e\napk add --no-cache curl unzip jq\n\nmkdir -p /mnt/server\ncd /mnt/server\n\necho \"Getting latest release URL...\"\nDOWNLOAD_URL=$(curl -fsSL https://api.github.com/repos/Extremelyd1/SSMP/releases/latest | jq -r '.assets[] | select(.name == \"SSMPServer-linux.zip\") | .browser_download_url')\n\nif [ -z \"$DOWNLOAD_URL\" ] || [ \"$DOWNLOAD_URL\" = \"null\" ]; then\n echo \"Failed to resolve download URL for SSMPServer-linux.zip\" >&2\n exit 1\nfi\n\necho \"Downloading from: ${DOWNLOAD_URL}\"\ncurl -fsSL -o SSMPServer-linux.zip \"${DOWNLOAD_URL}\"\n\necho \"Extracting files...\"\nunzip -o SSMPServer-linux.zip\nrm SSMPServer-linux.zip\n\necho \"Listing files:\"\nls -la\n\necho \"Setting permissions...\"\nchmod +x SSMPServer\n\necho \"Installation complete!\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README title uses "Silk Song"; the game name is typically written as "Silksong" (and your description line already uses "Silksong"). Please make the title consistent to avoid confusion/searchability issues.