Conversation
alokshukla631
left a comment
alokshukla631
left a comment
There was a problem hiding this comment.
This reads well to me. Calling out the transient-network case in the docstring should save people a trip through urllib3 internals.
nateprewitt
added
the
mass-automation-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring for
ChunkedEncodingErroronly mentions "server sent an invalid chunk" but this exception is also raised when the connection drops mid-stream during a chunked transfer (e.g. transient network interruption). The underlyingProtocolErrorfrom urllib3 covers both cases.Added a clarifying note to the docstring so users know this error can result from transient issues and that retrying may succeed. This aligns with the discussion in #7341 and #4771.
Fixes #7341