fix(nemo): route forward hardlink configs#1377
Open
mldangelo-oai wants to merge 1 commit into
Open
Conversation
Route renamed TAR-backed NeMo artifacts when a safe root model_config hardlink precedes its target member. Add routing and end-to-end CVE regression coverage plus unsafe-link negatives.
Contributor
Performance BenchmarksCompared
|
ianw-oai
approved these changes
May 27, 2026
ianw-oai
approved these changes
May 27, 2026
Contributor
ianw-oai
left a comment
There was a problem hiding this comment.
Focused routing fix with targeted NeMo/TAR coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_config.yamlhardlink precedes its payload memberNemoScannerBug
The recent renamed-NeMo content router promoted linked root configs only when a hardlink target had already appeared in the TAR stream. A valid renamed archive with
model_config.yamlas a forward hardlink therefore routed to the generic TAR scanner, bypassing existing CVE-2025-23304 Hydra_target_analysis even thoughNemoScanneralready resolves that target from its complete member index.Validation
tar != nemoPROMPTFOO_DISABLE_TELEMETRY=1 uv run pytest tests/utils/file/test_filetype.py tests/scanners/test_nemo_scanner.py tests/scanners/test_tar_scanner.py -q(320 passed)uv run ruff format modelaudit/ packages/modelaudit-picklescan/src packages/modelaudit-picklescan/tests tests/uv run ruff check --fix modelaudit/ packages/modelaudit-picklescan/src packages/modelaudit-picklescan/tests tests/uv run mypy modelaudit/ packages/modelaudit-picklescan/src packages/modelaudit-picklescan/tests tests/PROMPTFOO_DISABLE_TELEMETRY=1 uv run pytest -n auto -m "not slow and not integration" --maxfail=1(5984 passed, 16 skipped)npx prettier --check CHANGELOG.mdCI Triage
Nightly CIrun onmain(26433798500, May 26, 2026) passed; it had no failed job logs.