Repository navigation
metric: restrict constructor assignment to supported options - #866
Open
SidheshwarSarangal wants to merge 1 commit into
Open
SidheshwarSarangal wants to merge 1 commit into
SidheshwarSarangal wants to merge 1 commit into
Conversation
Ignore unexpected configuration fields while preserving common and subclass options. Add regression tests and document the behavior. Relates to prometheus#814 Signed-off-by: Sidheshwar Sarangal <sidheshwar.sarangal@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metric constructors currently copy arbitrary configuration properties onto the instance, allowing unexpected fields to replace methods or change its prototype.
Restrict assignment to common options and options declared by subclasses through their defaults. Preserve Histogram and Summary settings, ignore unknown options without evaluating their getters, and document the behavior.
Relates to #814.
Validation:
npm test -- --runInBandpassed, including lint, formatting, TypeScript checks, 664 tests, and 34 snapshots.AI assistance was used to prepare the implementation and tests.
@jdmarshall, does this approach fit the constructor changes you outlined in #814?