Skip to content

fix(sbom): fix tag field on cache hits and new entries #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
castrojo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(sbom): fix tag field on cache hits and new entries #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/fetch-github-sbom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,9 @@ async function processLatestTagStream(spec, existing) {
console.log(` ${spec.id}: ${cacheKey}${isCacheHit ? " (cache hit)" : ""}`);

if (isCacheHit) {
releases[cacheKey] = existingEntry;
// Update tag to cacheKey on every cache hit — idempotent migration from
// the old tag:imageRef format (which broke the nvidiaByTag lookup).
releases[cacheKey] = { ...existingEntry, tag: cacheKey };
} else {
console.log(` ${spec.id}: verifying attestation for ${imageRef}`);
const rawAttestation = await verifyAttestation(imageRef, spec);
Expand Down Expand Up @@ -414,7 +416,7 @@ async function processLatestTagStream(spec, existing) {
}

releases[cacheKey] = {
tag: imageRef,
tag: cacheKey,
imageRef,
digest: null,
attestation,
Expand Down