fix(sbom): store cacheKey as tag so nvidia overlay matches correctly#840
Conversation
buildStreamFromSbom does: nvidiaByTag?.[entry.tag || cacheKey] With tag=imageRef (e.g. ghcr.io/projectbluefin/dakota:latest), the lookup uses the full URL which is never in the nvidia map — and never falls through to the cacheKey fallback. Store tag=cacheKey (e.g. latest-20260514) so the nvidia version from dakota-nvidia-latest is matched correctly for every release. Assisted-by: Claude Sonnet 4.6 via pi
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates ChangesSBOM Cache Key Alignment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
buildStreamFromSbomlooks up nvidia versions withnvidiaByTag?.[entry.tag || cacheKey].\n\nWe were storingtag: imageRef(e.g.ghcr.io/projectbluefin/dakota:latest) — a truthy value that is never a key in the nvidia map. The fallback tocacheKeynever ran, so nvidia was alwaysnull.\n\nFix: storetag: cacheKey(e.g.latest-20260514). ThebuildNvidiaMapFromSbomStreamstores entries keyed by cacheKey, sonvidiaByTag['latest-20260514']correctly returns595.71.05."Summary by CodeRabbit