Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -451,16 +451,6 @@ Style/RedundantParentheses:
- "app/views/catalog/_document.atom.builder"
- "lib/railties/blacklight.rake"

# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
Exclude:
- "lib/blacklight.rb"
- "lib/blacklight/configuration/fields.rb"
- "lib/railties/blacklight.rake"

# Offense count: 32
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinSize.
Expand Down
2 changes: 1 addition & 1 deletion lib/blacklight.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def self.blacklight_yml
else
YAML.safe_load(blacklight_erb, [], [], true)
end
rescue => e
rescue StandardError => e
raise("#{blacklight_config_file} was found, but could not be parsed.\n#{e.inspect}")
end

Expand Down
2 changes: 1 addition & 1 deletion lib/blacklight/configuration/fields.rb
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def reflected_fields

@table[:reflected_fields] ||= Rails.cache.fetch("blacklight_configuration/admin/reflected_fields", expires_in: 1.hour) do
repository.reflect_fields
rescue => e
rescue StandardError => e
Blacklight.logger&.warn "Error retrieving field metadata: #{e}"
false
end
Expand Down
8 changes: 4 additions & 4 deletions lib/railties/blacklight.rake
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace :blacklight do
puts "Unable to reach: #{conn.uri}"
exit 1
end
rescue => e
rescue StandardError => e
puts e
exit 1
end
Expand Down Expand Up @@ -68,7 +68,7 @@ namespace :blacklight do
puts "\tdoc count: #{response.docs.length}"
puts "\tfacet fields: #{response.facets.length}"
end
rescue => e
rescue StandardError => e
errors += 1
puts e
end
Expand All @@ -90,7 +90,7 @@ namespace :blacklight do
puts "\tdoc count: #{docs.length}"
puts "\tfacet fields: #{response.facets.length}"
end
rescue => e
rescue StandardError => e
errors += 1
puts e
end
Expand All @@ -110,7 +110,7 @@ namespace :blacklight do
if verbose
puts "\tstatus: #{response.header['status']}"
end
rescue => e
rescue StandardError => e
errors += 1
puts e
end
Expand Down
Loading