Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -515,14 +515,6 @@ Style/RescueStandardError:
- "lib/blacklight/configuration/fields.rb"
- "lib/railties/blacklight.rake"

# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowAsExpressionSeparator.
Style/Semicolon:
Exclude:
- "spec/models/blacklight/solr/repository_spec.rb"
- "spec/views/catalog/_paginate_compact.html.erb_spec.rb"

# Offense count: 32
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinSize.
Expand Down
12 changes: 10 additions & 2 deletions spec/models/blacklight/solr/repository_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@
end

describe "setting to post" do
let (:blacklight_config) { config = Blacklight::Configuration.new; config.http_method = :post; config }
let (:blacklight_config) do
config = Blacklight::Configuration.new
config.http_method = :post
config
end

it "keep value set to post" do
expect(blacklight_config.http_method).to eq :post
Expand Down Expand Up @@ -210,7 +214,11 @@
end

describe "http_method configuration", :integration do
let (:blacklight_config) { config = Blacklight::Configuration.new; config.http_method = :post; config }
let (:blacklight_config) do
config = Blacklight::Configuration.new
config.http_method = :post
config
end

it "sends a post request to solr and get a response back" do
response = subject.search(params: { q: all_docs_query })
Expand Down
2 changes: 1 addition & 1 deletion spec/views/catalog/_paginate_compact.html.erb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
end

it "renders ActiveRecord collections" do
50.times { b = Bookmark.new; b.user = user; b.save! }
50.times { Bookmark.create!(user: user) }
render partial: 'catalog/paginate_compact', object: Bookmark.page(1).per(25)
expect(rendered).to have_css ".page-entries"
expect(rendered).to have_css "a[@rel=next]"
Expand Down
Loading