Skip to content

Combine two conditionals into one #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcoyne merged 1 commit into from
May 12, 2026
+2 −9
Merged

Combine two conditionals into one #3820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,13 +523,6 @@ Style/Semicolon:
- "spec/models/blacklight/solr/repository_spec.rb"
- "spec/views/catalog/_paginate_compact.html.erb_spec.rb"

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowModifier.
Style/SoleNestedConditional:
Exclude:
- "app/controllers/concerns/blacklight/controller.rb"

# Offense count: 32
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinSize.
Expand Down
4 changes: 2 additions & 2 deletions app/controllers/concerns/blacklight/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ def search_action_url options = {}
end

def search_action_path *args
if args.first.is_a? Hash
args.first[:only_path] = true if args.first[:only_path].nil?
if args.first.is_a?(Hash) && args.first[:only_path].nil?
args.first[:only_path] = true
end

search_action_url(*args)
Expand Down
Loading