Skip to content

Push presenter configuration up to the configuration #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanaery merged 1 commit into from
Aug 20, 2025
Merged

Push presenter configuration up to the configuration #3736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/blacklight/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def initialized_default_configuration?
# @return [Blacklight::Configuration::ViewConfig::Index]
property :index, default: ViewConfig::Index.new(
# document presenter class used by helpers and views
document_presenter_class: nil,
document_presenter_class: Blacklight::IndexPresenter,
# document presenter used for json responses
json_presenter_class: Blacklight::JsonPresenter,
# component class used to render a document
Expand Down Expand Up @@ -191,7 +191,7 @@ def initialized_default_configuration?
# @return [Blacklight::Configuration::ViewConfig::Show]
property :show, default: ViewConfig::Show.new(
# document presenter class used by helpers and views
document_presenter_class: nil,
document_presenter_class: Blacklight::ShowPresenter,
document_component: Blacklight::DocumentComponent,
document_thumbnail_component: nil,
show_tools_component: Blacklight::Document::ShowToolsComponent,
Expand Down
16 changes: 0 additions & 16 deletions lib/blacklight/configuration/view_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,6 @@ class Show < ViewConfig
# @return [Hash] Default route parameters for 'show' requests.
# Set this to a hash with additional arguments to merge into the route,
# or set `controller: :current` to route to the current controller.

def document_presenter_class
super || Blacklight::ShowPresenter
end

def to_h
super.merge(document_presenter_class: document_presenter_class)
end
end

class Index < ViewConfig
Expand All @@ -99,14 +91,6 @@ class Index < ViewConfig
# see Blacklight::Catalog#additional_response_formats for information about the OpenStruct data
# @!attribute collection_actions
# @return [String, Symbol]

def document_presenter_class
super || Blacklight::IndexPresenter
end

def to_h
super.merge(document_presenter_class: document_presenter_class)
end
end
end
end