Skip to content

remove GL / GLES dependency from projectMConfig for any platform other than WIN32#973

Merged
kblaschke merged 1 commit into
projectM-visualizer:masterfrom
mbaetgen-wup:fix/remove-gles-dependency
May 8, 2026
Merged

remove GL / GLES dependency from projectMConfig for any platform other than WIN32#973
kblaschke merged 1 commit into
projectM-visualizer:masterfrom
mbaetgen-wup:fix/remove-gles-dependency

Conversation

@mbaetgen-wup
Copy link
Copy Markdown
Collaborator

No description provided.

@mbaetgen-wup mbaetgen-wup changed the title remove GL / GLES dependency from projectMConfig from any platform other than WIN32 remove GL / GLES dependency from projectMConfig for any platform other than WIN32 Feb 28, 2026
@kblaschke
Copy link
Copy Markdown
Member

Does Windows really need to hard-link against opengl32.dll anymore? AFAIK the glad loader already loads it via LoadLibrary(). Apps using projectM will have to link or resolve GL calls anyways, so it's not really necessary to propagate the CMake dependency IMO.

@mbaetgen-wup
Copy link
Copy Markdown
Collaborator Author

as far as I know it's needed, but I will test it to make sure

@kblaschke
Copy link
Copy Markdown
Member

as far as I know it's needed, but I will test it to make sure

The test UI executable may need the dependency explicitly (but GLEW and the associated init call can be removed if not already done so).

Otherwise, glad loads opengl32.dll via LoadLibrary(), thus a hard linker dependency shouldn't be required here. Apps may do the same so we shouldn't force them to hard-link the library if not absolutely necessary.

@kblaschke
Copy link
Copy Markdown
Member

Tested it, the SDL2 test app doesn't need OpenGL dependencies either as SDL2 also loads OpenGL dynamically as well. So fully removing the OpenGL dependency from the build system is fine, as it's rather a runtime-only dependency now. This will certainly include Windows as well.

@kblaschke kblaschke force-pushed the fix/remove-gles-dependency branch from 4dd3fe5 to 4d28493 Compare May 8, 2026 12:07
Copy link
Copy Markdown
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's finally merge this one.

@kblaschke kblaschke merged commit 4d28493 into projectM-visualizer:master May 8, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants