[TC-DD-3.23] Update test script to verify commissioning window#72758
[TC-DD-3.23] Update test script to verify commissioning window#72758dengpan-liu wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TC_DD_3_23 test case by adding steps to verify that commissioning fails when attempted on an already commissioned device, including after a power event. The review feedback highlights a critical issue where the test only instructs the user to power off the device; if the device remains unpowered, the subsequent commissioning attempt will fail due to being offline rather than verifying the commissioning window state. The reviewer suggests updating both the test step description and the user prompt to instruct a full power cycle (power off, then power on).
| TestStep(2, 'Validate the NFC bit in payload and Perform the commissioning') | ||
| TestStep(2, "Validate the NFC bit in payload and Perform the commissioning"), | ||
| TestStep(3, "Perform the commissioning again to check if the device is already commissioned and commissioning fails"), | ||
| TestStep(4, "DUT is powered OFF."), |
There was a problem hiding this comment.
The step description says "DUT is powered OFF.", but to properly test that the commissioning window remains closed after a power cycle, the DUT needs to be powered back ON before attempting commissioning in Step 5. Otherwise, the commissioning attempt in Step 5 will fail simply because the device is offline/unpowered, rather than verifying the commissioning window state. Please update this step to indicate a power cycle.
| TestStep(4, "DUT is powered OFF."), | |
| TestStep(4, "Power cycle the DUT (Power OFF, then Power ON)."), |
| ) | ||
|
|
||
| self.step(4) | ||
| self.wait_for_user_input(prompt_msg="Power OFF the device") |
There was a problem hiding this comment.
The prompt only asks the user to "Power OFF the device". If the device remains powered off, the subsequent commissioning attempt in Step 5 will fail due to the device being offline, which does not validate the commissioning window behavior. Please update the prompt to ask the user to power cycle the device (Power OFF and then Power ON).
| self.wait_for_user_input(prompt_msg="Power OFF the device") | |
| self.wait_for_user_input(prompt_msg="Power cycle the DUT (Power OFF, then Power ON)") |
|
PR #72758: Size comparison from 74a0e7a to 1ba50de Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72758 +/- ##
==========================================
- Coverage 56.79% 56.60% -0.19%
==========================================
Files 1642 1642
Lines 112770 113136 +366
Branches 13139 13245 +106
==========================================
- Hits 64048 64044 -4
- Misses 48722 49092 +370 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Summary
Update python script to validate Commissioning Window close after DUT commissioned successfully through NFC based commissioning.
Cover DUT power up and power off situations.
Related issues
Test Plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/6195/
Testing
Run TC-DD-3.23.