Skip to content

[fuzz] Guard PASE fuzz harness against uninitialized verifier on Generate() failure #72749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alami-Amine wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fuzz] Guard PASE fuzz harness against uninitialized verifier on Generate() failure #72749

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d27ba35
[fuzz] Guard PASE fuzz harness against uninitialized verifier on Gene…
Alami-Amine Jun 26, 2026
0e01ae3
[fuzz] Use ReturnOnFailure for PASE verifier Generate() checks
Alami-Amine Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/protocols/secure_channel/tests/FuzzPASE_PW.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,10 @@ void TestPASESession::FuzzHandlePake1(const uint32_t fuzzedSetupPasscode, const

// Compute mPASEVerifier (in order for mSpake2p.BeginVerifier() to use it, once it is called by the pairingAccessory through
// HandleMsg1_and_SendMsg2)
RETURN_SAFELY_IGNORED pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode);
// If Generate() fails (the fuzz domains intentionally include out-of-range iter/salt),
// mPASEVerifier stays uninitialized; reading it below (BeginVerifier / HandleMsg*) would be an
// MSan false positive that cannot occur in production, which checks Generate(). Bail instead.
VerifyOrReturn(pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode) == CHIP_NO_ERROR);

/************************Injecting Fuzzed Pake1 Message into PaseSession::OnMessageReceived*************************/

Expand Down Expand Up @@ -750,7 +753,10 @@ void TestPASESession::FuzzHandlePake2(const uint32_t fuzzedSetupPasscode, const

// Below Steps take place in HandleMsg1
// Compute mPASEVerifier to be able to pass it to BeginVerifier()
RETURN_SAFELY_IGNORED pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode);
// If Generate() fails (the fuzz domains intentionally include out-of-range iter/salt),
// mPASEVerifier stays uninitialized; reading it below (BeginVerifier / HandleMsg*) would be an
// MSan false positive that cannot occur in production, which checks Generate(). Bail instead.
VerifyOrReturn(pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode) == CHIP_NO_ERROR);
Comment thread
Alami-Amine marked this conversation as resolved.
Outdated

RETURN_SAFELY_IGNORED pairingAccessory.mSpake2p.BeginVerifier(nullptr, 0, nullptr, 0, pairingAccessory.mPASEVerifier.mW0,
kP256_FE_Length, pairingAccessory.mPASEVerifier.mL,
Expand Down Expand Up @@ -880,7 +886,10 @@ void TestPASESession::FuzzHandlePake3(const uint32_t fuzzedSetupPasscode, const

// Below Steps take place in HandleMsg1
// compute mPASEVerifier to be able to pass it to BeginVerifier()
RETURN_SAFELY_IGNORED pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode);
// If Generate() fails (the fuzz domains intentionally include out-of-range iter/salt),
// mPASEVerifier stays uninitialized; reading it below (BeginVerifier / HandleMsg*) would be an
// MSan false positive that cannot occur in production, which checks Generate(). Bail instead.
VerifyOrReturn(pairingAccessory.mPASEVerifier.Generate(fuzzedPBKDF2Iter, fuzzedSaltSpan, fuzzedSetupPasscode) == CHIP_NO_ERROR);

RETURN_SAFELY_IGNORED pairingAccessory.mSpake2p.BeginVerifier(nullptr, 0, nullptr, 0, pairingAccessory.mPASEVerifier.mW0,
kP256_FE_Length, pairingAccessory.mPASEVerifier.mL,
Expand Down
Loading