[Dynamic Lighting cluster] Add code-driven server layout#72744
Open
Yuri-Chenyu wants to merge 2 commits into
Open
[Dynamic Lighting cluster] Add code-driven server layout#72744Yuri-Chenyu wants to merge 2 commits into
Yuri-Chenyu wants to merge 2 commits into
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the server-side implementation of the provisional DynamicLighting cluster, including its data model definitions, codegen integration, build configurations, and unit tests. The review feedback highlights a critical potential out-of-bounds array access in CodegenIntegration.cpp that requires defensive bounds checking, a build system structure violation in app_config_dependent_sources.cmake regarding which source files should be listed, and a minor recommendation to use more idiomatic C++ value-initialization for nullable types in DynamicLightingCluster.cpp.
Yuri-Chenyu
force-pushed
the
dl-pr2-server-layout-clean
branch
from
5b5c989 to
718fba2
Compare
|
PR #72744: Size comparison from 413ff63 to 718fba2 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72744 +/- ##
==========================================
+ Coverage 56.79% 56.81% +0.01%
==========================================
Files 1642 1644 +2
Lines 112757 112808 +51
Branches 13139 13139
==========================================
+ Hits 64040 64091 +51
Misses 48717 48717 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Yuri-Chenyu
force-pushed
the
dl-pr2-server-layout-clean
branch
from
fb1705f to
842cbb6
Compare
|
PR #72744: Size comparison from 413ff63 to 842cbb6 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Contributor
Author
|
@andy31415 All checks are passing now after rebasing and resolving the build graph conflict. Could you please review when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the initial code-driven Dynamic Lighting server layout.
This includes server registration through
CodegenClusterIntegration, all-clusters app wiring, mandatory attribute exposure, accepted command exposure, and placeholder read/write/command behavior.Full effect state management, delegate-backed behavior, complete
CurrentSpeedwrite semantics, cross-cluster lighting interactions, and chip-tool/client support will be added in follow-up PRs.Related issues
None.
Testing
TestDynamicLightingClusterTestDynamicLightingClusterchip-all-clusters-appbuild