Enable Groupcast cluster on light-switch sample-app#72740
Open
jmartinez-silabs wants to merge 3 commits into
Open
Enable Groupcast cluster on light-switch sample-app#72740jmartinez-silabs wants to merge 3 commits into
jmartinez-silabs wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the provisional Groupcast cluster (cluster 101) for the light-switch-app across various platforms, updating the .matter and .zap files to include the cluster's attributes, commands, and events. However, in the ESP32 configuration, the Groupcast flag is missing the required 'CONFIG_' prefix, which will cause the build system to ignore it.
jmartinez-silabs
force-pushed
the
re-enable_groupcast_light_switch
branch
from
5ad86e9 to
d25a9f9
Compare
|
PR #72740: Size comparison from 413ff63 to d25a9f9 Full report (3 builds for cc32xx, stm32)
|
|
PR #72740: Size comparison from 413ff63 to bb6a069 Increases above 0.2%:
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72740 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 1642 1642
Lines 112757 112757
Branches 13139 13139
=======================================
Hits 64040 64040
Misses 48717 48717 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lpbeliveau-silabs
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Light-switch app do not have Groupcast cluster. The light-switch app is used as reference app for Binding test as TH sending commands to the bound device and shall be able to use Groupcast do for 1.6.1+
Solution
This is a redo of #71439 during 1.6 dev which was eventually reverted as groupcast remained provisional in 1.6
What is done:
chip_config_enable_groupcast=true, for all platforms running this sample-app, to enable currently gated groupcast code paths. For some platform this is done through KConfigs/cmakes configs usingCONFIG_CHIP_ENABLE_GROUPCAST=yRelated issues
fixes #71499
Testing
Build, commission Light-switch on Silabs MG24. Confirm Presence of Groupcast cluster with feature map SD & PGA