Add the application-side logic of the Ambient Context Sensing cluster server handler to all-devices-app#72731
Open
crlonxp wants to merge 6 commits into
Open
Add the application-side logic of the Ambient Context Sensing cluster server handler to all-devices-app#72731crlonxp wants to merge 6 commits into
crlonxp wants to merge 6 commits into
Conversation
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the ambient context sensor device type in the all-devices-app example, including its device implementation, build configurations, and named-pipe command handlers for cluster interaction. The review feedback highlights a typo in the CMake configuration file (#cmakedevice01 instead of #cmakedefine01), recommends deduplicating the GetAmbientContextType helper function in AppCommandDelegate.cpp by moving it to an anonymous namespace, and suggests adding validation for the confidence value in SetPredictedActivityCommandHandler to prevent invalid casts to chip::Percent.
for more information, see https://pre-commit.ci
Remove the duplicate function Add more input checking Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
for more information, see https://pre-commit.ci
|
PR #72731: Size comparison from 9dc6ceb to c6448ac Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, realtek, stm32)
|
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72731 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 1642 1642
Lines 112770 112770
Branches 13139 13139
=======================================
Hits 64048 64048
Misses 48722 48722 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72731: Size comparison from 9dc6ceb to d809827 Increases above 0.2%:
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the application-layer implementation in app-devices-app for the Ambient Context Sensing cluster server handler to support state configuration via a named pipe for Python tests.
Related Python test PR: #43197
Testing
All test cases from the related Python test PR have been executed and passed successfully:
#43197