Skip to content

[Fix]Updating TC_OPSTATE_2_5 and 6 replace PIXIT.WAITTIME.REBOOT with framework reboot functionality#72727

Open
j-ororke wants to merge 2 commits into
project-chip:masterfrom
j-ororke:reboot-opstate-tests_remove-pixit-waittime-reboot
Open

[Fix]Updating TC_OPSTATE_2_5 and 6 replace PIXIT.WAITTIME.REBOOT with framework reboot functionality#72727
j-ororke wants to merge 2 commits into
project-chip:masterfrom
j-ororke:reboot-opstate-tests_remove-pixit-waittime-reboot

Conversation

@j-ororke

@j-ororke j-ororke commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaced PIXIT.WAITTIME.REBOOT with framework function request_device_reboot() as this works for reboots in test framework:

  • TC_OPSTATE_2_5: disables background wildcard subscription so that it doesn’t interfere after reboot during this test, and replaced functionality in test step 15 in OpstateCommon.py
  • TC_OVENOPSTATE_2_5.py: disables background wildcard subscription so that it doesn’t interfere after reboot during this test, and replaced functionality in test step 15 OpstateCommon.py
  • TC_OPSTATE_2_6: This had the PIXIT.WAITTIME.REBOOT in the CI args for this test, but did not appear to be using it in the test in OpstateCommon.py, so just removed PIXIT.WAITTIME.REBOOT from CI args
  • TC_OVENOPSTATE_2_6.py: This had the PIXIT.WAITTIME.REBOOT in the CI args for this test, but did not appear to be using it in the test in OpstateCommon.py, so just removed PIXIT.WAITTIME.REBOOT from CI args

Related issues

Fixes: project-chip/matter-test-scripts#660

Testing

TC_OPSTATE_2_5:

scripts/tests/run_python_test.py --factory-reset   --app out/linux-x64-all-clusters/chip-all-clusters-app   --app-args "--discriminator 1234 --passcode 20202021 --KVS kvs1 --app-pipe /tmp/opstate_2_5_fifo"   --app-ready-pattern "APP STATUS: Starting event loop"   --script-args "--storage-path admin_storage.json --discriminator 1234 --passcode 20202021 --PICS src/app/tests/suites/certification/ci-pics-values --endpoint 1 --commissioning-method on-network --app-pipe /tmp/opstate_2_5_fifo"   --script src/python_testing/TC_OPSTATE_2_5.py

TC_OVENOPSTATE_2_5:

scripts/tests/run_python_test.py --factory-reset   --app out/linux-x64-all-clusters/chip-all-clusters-app   --app-args "--discriminator 1234 --passcode 20202021 --KVS kvs1 --app-pipe /tmp/ovenopstate_2_5_fifo"   --app-ready-pattern "APP STATUS: Starting event loop"   --script-args "--storage-path admin_storage.json --discriminator 1234 --passcode 20202021 --PICS src/app/tests/suites/certification/ci-pics-values --endpoint 1 --commissioning-method on-network --app-pipe /tmp/ovenopstate_2_5_fifo"   --script src/python_testing/TC_OVENOPSTATE_2_5.py

TC_OPSTATE_2_6:

scripts/tests/run_python_test.py --factory-reset   --app out/linux-x64-all-clusters/chip-all-clusters-app   --app-args "--discriminator 1234 --passcode 20202021 --KVS kvs1 --app-pipe /tmp/opstate_2_6_fifo"   --script-args "--storage-path admin_storage.json --discriminator 1234 --passcode 20202021 --PICS src/app/tests/suites/certification/ci-pics-values --endpoint 1 --commissioning-method on-network --app-pipe /tmp/opstate_2_6_fifo"   --script src/python_testing/TC_OPSTATE_2_6.py

TC_OVENOPSTATE_2_6:

scripts/tests/run_python_test.py --factory-reset   --app out/linux-x64-all-clusters/chip-all-clusters-app   --app-args "--discriminator 1234 --passcode 20202021 --KVS kvs1 --app-pipe /tmp/ovenopstate_2_6_fifo"   --script-args "--storage-path admin_storage.json --discriminator 1234 --passcode 20202021 --PICS src/app/tests/suites/certification/ci-pics-values --endpoint 1 --commissioning-method on-network --app-pipe /tmp/ovenopstate_2_6_fifo"   --script src/python_testing/TC_OVENOPSTATE_2_6.py

…REBOOT with request_device_reboot framework reboot function
@j-ororke j-ororke self-assigned this Jun 25, 2026
@github-actions github-actions Bot added the tests label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DUT reboot process in the operational state tests by replacing the manual wait time (PIXIT.WAITTIME.REBOOT) with a more robust device reboot request mechanism. It updates the test logic to handle both CI and manual testing environments by expiring sessions and re-establishing subscriptions after a reboot, while also disabling background wildcard subscriptions to prevent stale cache issues. No review comments were provided for this pull request.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

PR #72727: Size comparison from b13372f to fed11be

Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
platform target config section b13372f fed11be change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098908 1098908 0 0.0
RAM 133418 133418 0 0.0
bl702 lighting-app bl702+eth FLASH 1085716 1085716 0 0.0
RAM 109029 109029 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 882208 882208 0 0.0
RAM 108596 108596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 777352 777352 0 0.0
RAM 103404 103404 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 790096 790096 0 0.0
RAM 108684 108684 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 739368 739368 0 0.0
RAM 97612 97612 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 719540 719540 0 0.0
RAM 97644 97644 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 569646 569646 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 597198 597198 0 0.0
RAM 205272 205272 0 0.0
efr32 lighting-app BRD4187C FLASH 1094924 1094924 0 0.0
RAM 135256 135256 0 0.0
lock-app BRD4187C FLASH 995152 995152 0 0.0
RAM 131292 131292 0 0.0
BRD4338a FLASH 799793 799793 0 0.0
RAM 243432 243432 0 0.0
esp32 all-clusters-app c3devkit DRAM 99556 99556 0 0.0
FLASH 1626112 1626112 0 0.0
IRAM 94776 94776 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 844732 844732 0 0.0
RAM 157771 157771 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1750708 1750708 0 0.0
RAM 215492 215492 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1626532 1626532 0 0.0
RAM 211604 211604 0 0.0
light cy8ckit_062s2_43012 FLASH 1470844 1470844 0 0.0
RAM 197436 197436 0 0.0
lock cy8ckit_062s2_43012 FLASH 1504292 1504292 0 0.0
RAM 225268 225268 0 0.0
qpg lighting-app qpg6200+debug FLASH 843140 843140 0 0.0
RAM 127908 127908 0 0.0
lock-app qpg6200+debug FLASH 782976 782976 0 0.0
RAM 118840 118840 0 0.0
realtek light-switch-app rtl8777g FLASH 689344 689344 0 0.0
RAM 101780 101780 0 0.0
lighting-app rtl8777g FLASH 730288 730288 0 0.0
RAM 102052 102052 0 0.0
stm32 light STM32WB5MM-DK FLASH 478968 478968 0 0.0
RAM 141492 141492 0 0.0
telink all-devices-app tl7218x FLASH 851100 851100 0 0.0
RAM 99060 99060 0 0.0
tlsr9118bdk40d FLASH 642700 642700 0 0.0
RAM 120192 120192 0 0.0
bridge-app tl7218x FLASH 734136 734136 0 0.0
RAM 97700 97700 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 800666 800666 0 0.0
RAM 42380 42380 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl7218x FLASH 845806 845806 0 0.0
RAM 101492 101492 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 734688 734688 0 0.0
RAM 57824 57824 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 795776 795776 0 0.0
RAM 75176 75176 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 734604 734604 0 0.0
RAM 34480 34480 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 615198 615198 0 0.0
RAM 118508 118508 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 842022 842026 4 0.0
RAM 97376 97376 0 0.0

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.80%. Comparing base (b13372f) to head (fed11be).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72727   +/-   ##
=======================================
  Coverage   56.80%   56.80%           
=======================================
  Files        1639     1639           
  Lines      112751   112751           
  Branches    13136    13136           
=======================================
  Hits        64048    64048           
  Misses      48703    48703           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j-ororke j-ororke marked this pull request as ready for review June 25, 2026 03:26
@j-ororke j-ororke changed the title [Test Update]Updating TC_OPSTATE_2_5 and 6 to replace PIXIT.WAITTIME.REBOOT with framework reboot functionality [Test Update]Updating TC_OPSTATE_2_5 and 6 replace PIXIT.WAITTIME.REBOOT with framework reboot functionality Jun 25, 2026
@j-ororke j-ororke changed the title [Test Update]Updating TC_OPSTATE_2_5 and 6 replace PIXIT.WAITTIME.REBOOT with framework reboot functionality [Fix]Updating TC_OPSTATE_2_5 and 6 replace PIXIT.WAITTIME.REBOOT with framework reboot functionality Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

OPSTATE: Get rid of PIXIT.WAITTIME.REBOOT and actually reboot the CI

1 participant