Add protobuf-compiler to crossbuild intermediate containers#594
Merged
yujinkim-msft merged 1 commit intoproject-akri:mainfrom Jun 6, 2023
Merged
Conversation
diconico07
requested review from
Britel,
adithyaj,
bfjelds,
jiria,
kate-goldenring and
romoh
as code owners
Contributor
Author
|
/add-build-dependency-containers-label |
Contributor
|
👋 Added [build dependency containers] label :)! |
1 similar comment
Contributor
|
👋 Added [build dependency containers] label :)! |
Contributor
Author
|
/add-same-version-label |
Contributor
|
👋 Added [same version] label :)! |
Contributor
|
👋 Added [same version] label :)! |
diconico07
force-pushed
the
add-protobuf-compiler-intermediate
branch
from
de9178f to
6002b01
Compare
Contributor
|
@diconico07 I think we will want to update the opencv docker container before this pr or in addition to it #580 |
8 tasks
Needed by project-akri#593 for prost upgrade Signed-off-by: Nicolas Belouin <[email protected]>
diconico07
force-pushed
the
add-protobuf-compiler-intermediate
branch
from
6002b01 to
520ab2c
Compare
kate-goldenring
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add protobuf-compiler to intermediate containers, this is needed for prost upgrade (c.f #593 )
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)