Match or exceed v1 performance#580
Open
jhollinger wants to merge 49 commits into
Open
Conversation
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
4 times, most recently
from
cf26f1a to
43f7db0
Compare
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
18 times, most recently
from
98b34e4 to
5841499
Compare
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
from
e83ea61 to
b3d8412
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
2 times, most recently
from
b5543f8 to
a5cf165
Compare
…result hook to run, so that it's easier for other extensions to decorate the result before it's JSONified Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…eprint's views from V2 Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…d Procs Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
from
a5cf165 to
c065be7
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
7 times, most recently
from
b9d79a6 to
2dc9670
Compare
- No longer need `use!` since `use` is now positional. - The DSL now builds a series of nodes which are evaled later. - Replace `view`'s `empty` arg with the `exclude_all` DSL method. - Options and extensions are now blocks (so they can interact properly with other DSL nodes) Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…DSL methods Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…artials can be inherited Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
jhollinger
force-pushed
the
jh/release-2.0-faster
branch
from
2dc9670 to
6e5c009
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…hods in V2::Base Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…ir own views in associations (without using a Proc). Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…xtensions Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…icated methods Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…d/missing partials. Helpful because the `use` could be located in a parent Blueprint, parent view, or a nested `use`. Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
…ents from partials. `exclude` now only works on inheritance. `use` has its own exclusion arguments. Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After V1's recent perf improvements, V2 wasn't looking so great. These changes make V2 competitive again:
Some major changes include:
useto behave like a macro within the DSL.around_blueprint_initcan now modify blueprint options and field details.