Skip to content

fix: replace placeholder alt text on people portraits#1306

Open
rushdarshan wants to merge 6 commits intoprocessing:mainfrom
rushdarshan:fix/people-alt-text
Open

fix: replace placeholder alt text on people portraits#1306
rushdarshan wants to merge 6 commits intoprocessing:mainfrom
rushdarshan:fix/people-alt-text

Conversation

@rushdarshan
Copy link
Copy Markdown

@rushdarshan rushdarshan commented Apr 6, 2026 •
edited
Loading

Summary

  • replace placeholder alt text for Kenneth Lim portrait
  • replace placeholder alt text for Stalgia Grigg portrait

Why

  • fixes accessibility issue where screen readers announced placeholder text instead of useful portrait descriptions

Testing

  • verified source content now uses descriptive imageAlt values in both people entries

Closes #1299

@rushdarshan
fix: normalize p5 reference links in parameter sections
4bd7500 
Fixes processing#674

The regex in normalizeP5ReferenceLinks() was capturing the 'p5'
prefix in the capture group, causing duplicate 'p5' in URLs.

Before: #/p5/rectMode -> /reference/p5/p5/rectMode/ (broken)
After:  #/p5/rectMode -> /reference/p5/rectMode/ (fixed)

Updated regex to exclude 'p5' from capture group while still
handling both dot notation (#/p5.Element) and slash notation
(#/p5/rectMode) patterns.
@rushdarshan
Merge branch 'main' of https://github.com/rushdarshan/p5.js-website
dfb673e
@rushdarshan
fix(people): replace placeholder portrait alt text
5ac84d4
@rushdarshan
fix(sketches): enable OpenProcessing embed rendering with proper sand…
ba70b11 
…box attributes
ksen0
ksen0 reviewed Apr 7, 2026
View reviewed changes
Comment thread src/layouts/ReferenceItemLayout.astro Outdated
return html.replace(
/href="#\/(p5\.[^"]+)"/g,
'href="/reference/p5/$1/"'
/href="#\/p5([.\/][^"]+)"/g,
Copy link
Copy Markdown
Member

@ksen0 ksen0 Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rushdarshan please reverr changes not related to the issue/PR, thank you!

ksen0
ksen0 requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ksen0 ksen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the branch but there's some unrelated code. Do you mind reverting this? Thanks!

@rushdarshan rushdarshan force-pushed the fix/people-alt-text branch from 6e02083 to 97cb6db Compare April 7, 2026 12:42
@rushdarshan
Copy link
Copy Markdown
Author

rushdarshan commented Apr 7, 2026

Done, reverted the unrelated commit. Ready for re-review.

@doradocodes doradocodes requested a review from ksen0 April 13, 2026 17:05
@Nwakaego-Ego
Copy link
Copy Markdown
Collaborator

Nwakaego-Ego commented Apr 28, 2026

Hi @doradocodes, I tested this PR locally and confirmed the alt text fix is working correctly. This one is ready to merge.

ksen0
ksen0 requested changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ksen0 ksen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, but this PR contains unrelated commits (eg "fix(sketches): enable OpenProcessing embed rendering with proper sandbox attributes"), so unfortunately I do not think this is ready to merge. I would recommend working on separate branches for each topic to avoid this problem. Thanks for understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksen0 ksen0 ksen0 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

People page: contributor portraits have placeholder alt text ("WRITE ALT TEXT HERE")

3 participants

@rushdarshan @Nwakaego-Ego @ksen0