perf: faster relabeling for several variants including SAUF#43
Open
william-silversmith wants to merge 19 commits into
Open
perf: faster relabeling for several variants including SAUF#43william-silversmith wants to merge 19 commits into
william-silversmith wants to merge 19 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi YACCLAB maintainers!
I was running some experiments on YACCLAB and noticed in profiling that relabeling was contributing more time than I expected for variants that work one-pixel/voxel at a time. It's not a huge amount of time, but it is a constant tax against these variants that makes them look worse than they are and in-between them, softens the contribution of a faster first-pass.
I also fixed some compiler warnings.
I re-ran the 8-connected benchmark to demonstrate that there is a material speedup on these variants. The chip was a Macbook Pro M3. I did run them simultaneously, but I think that should be ok on this machine.
I've attached the results of my runs.
Here are some samples though:
Before
After
I hope you find this a useful contribution.
Sincerely,
Will Silversmith
faster_relabel.zip
master.zip