fix(web): prevent UTM click handler from breaking cross-app navigation#7798
Merged
AmanVarshney01 merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(web): prevent UTM click handler from breaking cross-app navigation#7798AmanVarshney01 merged 1 commit intomainfrom
AmanVarshney01 merged 1 commit intomainfrom
Conversation
…igation
router.push() only works for pages owned by the current Next.js app.
The UTM persistence click handler was using it for every same-origin
link, which broke navigation to pages served by other apps:
- Site app: /docs and /blog are proxied via rewrites to separate
origins. router.push() tried client-side routing to a page that
doesn't exist in the site app — click did nothing.
- Blog app: has basePath "/blog", so router.push("/pricing") became
/blog/pricing — 404.
Now each app only uses router.push() for paths it owns. Cross-app
links fall through to anchor.setAttribute(), letting the browser
do a full navigation where server rewrites apply correctly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughTwo Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
AmanVarshney01
changed the title
mhartington
approved these changes
Apr 15, 2026
mhessdev
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/?utm_term=devrel) did nothing —router.push("/docs")tried client-side routing to a proxied path that doesn't exist as a page in the site app/blog?utm_term=devrel→ 404 becauserouter.push("/pricing")gotbasePath: "/blog"prepended →/blog/pricingrouter.push()for paths it owns. Cross-app links fall through toanchor.setAttribute()so the browser does a full navigation and server rewrites apply correctlySummary by CodeRabbit
Release Notes