Repository navigation
chore: relax click upper bound to <9 - #388
Merged
Merged
Conversation
Vitor-Avila
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax the
clickupper bound from<8.2to<9.preset-cli0.3.10–0.3.12 declareclick>=8.0.3,<8.2, whiledbt-core1.11.x requiresclick>=8.3.0,<9.0. The two can't be installed in the same environment, so users of both can't upgrade either one.pip install preset-cli==0.3.12 dbt-core==1.11.15fails withResolutionImpossible.Why the cap was there
The cap was added in #355 because click 8.2 changed command naming: it now strips the suffixes
_command,_cmd,_groupand_grpfrom a decorated function's name. Only one test fixture depended on this, so the product code is unaffected.Changes
setup.cfg:click>=8.0.3,<8.2→click>=8.0.3,<9tests/cli/superset/main_test.py: the fixture command now sets its name explicitly (@click.command(name="source-command")), so the test passes on every click versiondev-requirements-3.{10,11,12}.txt:click==8.1.8→click==8.5.0, so the pinned-dependency CI job exercises the newer clickCHANGELOG.rst: entry added under "Next"Testing
On Python 3.11:
pre-commit run --all-filespasses--helpoutput of everypreset-cliandsuperset-clicommand across click 8.1.8, 8.3.3 and 8.5.0, and it is identical. The parsed values of thedelete-assetsflags (including--dry-run/--no-dry-run) and ofsync nativeare also identical, both directly and throughmutate_commandspreset-cliinstalls alongsidedbt-core==1.11.15(pip resolves click 8.5.0)I have not run the 3.10 and 3.12 jobs locally, so CI will be the first run of those.
Things to be aware of
preset-cliorsuperset-cliwith no arguments prints the help and exits with code 2 instead of 0. This is click's behavior, not something changed here.CliRunner.isolated_filesystem()intests/cli/export_users_test.py. It still works on 8.x, and I left it alone to keep this PR small, so the<9cap stays.