Skip to content

Add support for wix files #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kvan7 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Add support for wix files #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions identify/extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,15 @@
'wav': {'binary', 'audio', 'wav'},
'webp': {'binary', 'image', 'webp'},
'whl': {'binary', 'wheel', 'zip'},
'wixproj': {'text', 'xml', 'wix'},
Copy link
Copy Markdown
Member

@asottile asottile Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these shouldn't all have the same tag since semantically the extensions mean different things?

Copy link
Copy Markdown
Author

@Kvan7 Kvan7 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just done them all with the same since they were related & to group them. I don't really have much preference though so I can change them to be individual if that matches the convention other files use better

'wkt': {'text', 'wkt'},
'woff': {'binary', 'woff'},
'woff2': {'binary', 'woff2'},
'wsdl': {'text', 'xml', 'wsdl'},
'wsgi': {'text', 'wsgi', 'python'},
'wxi': {'text', 'xml', 'wix'},
'wxl': {'text', 'xml', 'wix'},
'wxs': {'text', 'xml', 'wix'},
'xhtml': {'text', 'xml', 'html', 'xhtml'},
'xacro': {'text', 'xml', 'urdf', 'xacro'},
'xcconfig': {'text', 'xcconfig', 'xcodebuild'},
Expand Down
Loading