pt-PT translation

[maghuro]

add pt-PT translation and fix some bugs related to translation

[ner00]

Line 1674 (translation.json) needs some correction.

[maghuro]

Line 1674 (translation.json) needs some correction.

How dare you, correcting me in my own language? ahah

Good catch! Thank you!

[ner00]

How dare you, correcting me in my own language? ahah

I guess we have something in common then ;)

[prasathmani]

@maghuro , I appreciate the PR! Please give me a little time, and I'll review and merge it.

[Maikuolan]

The title for this pull request is "pt-PT translation", which suggests its intention is to introduce translations for European Portuguese to tinyfilemanager, but I see it also contains corrections to the German translations, to the Brazilian Portuguese translations, fixes a few typos in the main tinyfilemanager.php file (e.g., Dailog -> Dialog), and introduces various other changes to that main file, too.

I think it would be better to split this up into multiple, separate, distinct pull requests. IMO, a pull request should just achieve whatever its suggested intention is, which is most cases, will just be achieving one specific thing, e.g., fixing a bug, fixing some typos, new translations, implementing a new feature or whatever else. All these things are good things to do, of course, but it's easier for maintainers to properly review and manage pull requests when each pull request has a narrow, specific focus. Better to have multiple, smaller pull requests, rather than just one giant pull request.

[maghuro]

The title for this pull request is "pt-PT translation", which suggests its intention is to introduce translations for European Portuguese to tinyfilemanager, but I see it also contains corrections to the German translations, to the Brazilian Portuguese translations, fixes a few typos in the main tinyfilemanager.php file (e.g., Dailog -> Dialog), and introduces various other changes to that main file, too.

I think it would be better to split this up into multiple, separate, distinct pull requests. IMO, a pull request should just achieve whatever its suggested intention is, which is most cases, will just be achieving one specific thing, e.g., fixing a bug, fixing some typos, new translations, implementing a new feature or whatever else. All these things are good things to do, of course, but it's easier for maintainers to properly review and manage pull requests when each pull request has a narrow, specific focus. Better to have multiple, smaller pull requests, rather than just one giant pull request.

Thank you for the careful review. I agree that this pull request grew beyond the scope suggested by its title.

Because the branch is now several months behind "master", I will not rebase the mixed set of changes as-is. Instead, I am rebuilding the work from the current upstream "master" and splitting it into focused pull requests:

1. A pt-PT translation refresh, changing only "translation.json".
2. A small i18n fix for the remaining hard-coded UI labels in "tinyfilemanager.php".

I will leave out the unrelated German and pt-BR edits, and I will not duplicate fixes that have since landed upstream. Once the replacement pull requests are open, I will close this superseded one.

Thanks again.

[maghuro]

Thank you for the review. I agree that the original pull request had grown beyond the scope suggested by its title.

I rebuilt the work from the current upstream master and split it into two focused pull requests:

• i18n: localize remaining hard-coded UI strings #1423 — i18n: localize remaining hard-coded UI strings
• pt-PT: refresh and complete the European Portuguese translation #1424 — pt-PT: refresh and complete the European Portuguese translation

The replacement PRs intentionally exclude the unrelated German and Brazilian Portuguese changes, and fixes that had already landed upstream were not duplicated.

Closing this pull request as superseded by #1423 and #1424. Thank you again for the guidance.