Repository navigation
Escape values interpolated into Drive queries - #1
Closed
pragmabits wants to merge 1 commit into
Closed
pragmabits wants to merge 1 commit into
pragmabits wants to merge 1 commit into
Conversation
list_spreadsheets, list_folders and search_spreadsheets built their Drive query by dropping caller-supplied values straight into a quoted term. An apostrophe in the value closes that term early and whatever follows is read as query syntax: searching for "x' or mimeType != 'nope" produced a query whose mimeType filter no longer constrained anything, so the call could return arbitrary Drive files instead of spreadsheets. Escape backslashes and quotes before interpolating, handling the backslash first so an escaped quote in the input stays escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
list_spreadsheets,list_foldersandsearch_spreadsheetsbuild their Drive query by dropping caller-supplied values straight into a quoted term. An apostrophe closes that term early and whatever follows is read as query syntax.Searching for
x' or mimeType != 'nopeproduces:The
mimeTypefilter no longer constrains anything, so the call can return arbitrary Drive files instead of spreadsheets.Change
Adds
_escape_query_value()and applies it at the three interpolation points. Backslashes are escaped before quotes, so an already-escaped quote in the input stays escaped.Notes
mimeTypefilter.