Repository navigation
Better Unit Tests - Measure coverage once in CI, and fail below 100% - #3
Merged
Merged
Conversation
Every job in the matrix measured coverage and printed it, and none failed on it, so the same summary was computed three times per push and a change leaving code untested still passed. Measure it on PHP 8.3 alone, and run tests/coverage-gate.php after the suite. PHPUnit reports coverage without enforcing it, so the gate reads the clover report and fails the job when the lines or methods of src fall below 100%. The 8.1 and 8.2 jobs run the unit tests without a coverage driver. phpunit.xml no longer reports coverage on every run. composer coverage prints the summary on request, and composer coverage-gate runs what CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every job in the matrix measured coverage and printed it, and none failed on it, so the same summary was computed three times per push and a change leaving code untested still passed.
Measure it on PHP 8.3 alone, and run tests/coverage-gate.php after the suite. PHPUnit reports coverage without enforcing it, so the gate reads the clover report and fails the job when the lines or methods of src fall below 100%. The 8.1 and 8.2 jobs run the unit tests without a coverage driver.
phpunit.xml no longer reports coverage on every run. composer coverage prints the summary on request, and composer coverage-gate runs what CI runs.