Fix LoadRequested sent to all users in multiplayer rooms#410
Open
smoogipoo wants to merge 4 commits intoppy:masterfrom
Open
Fix LoadRequested sent to all users in multiplayer rooms#410smoogipoo wants to merge 4 commits intoppy:masterfrom
LoadRequested sent to all users in multiplayer rooms#410smoogipoo wants to merge 4 commits intoppy:masterfrom
Conversation
On its own, this commit is not intended to change anything except adjust the tests slightly so that a future failing test can be added.
Contributor
Author
|
The number of test changes here makes me feel a bit uneasy, as if option 3 from the OP is the better one to go down... Let's treat this PR as an RFC. |
Collaborator
Without real full-stack testing I'm kind of unbothered by anything in here? Unsure whether this is because of lack of bothering capacity or there's really not much to see here. |
Contributor
Author
|
Maybe it's just me being a bit too critical. |
Member
|
@smoogipoo shall we give this another try? needs some conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 to fixing ppy/osu#36045, and mentioned as bullet point 1 in ppy/osu#36121:
I'm not 100% sure on this change in principle, and there are 3 paths that we can go down here:
.Users(). This seems like it'd be a more complex change.LoadRequestedto all users in the room and handle this locally in the client.