Skip to content

Release 1.4.3#675

Merged
fellowship-merge-bot[bot] merged 2 commits into
polkadot-fellows:mainfrom
Snowfork:release-1-4-3
Apr 16, 2025
Merged

Release 1.4.3#675
fellowship-merge-bot[bot] merged 2 commits into
polkadot-fellows:mainfrom
Snowfork:release-1-4-3

Conversation

@claravanstaden
Copy link
Copy Markdown
Contributor

@claravanstaden claravanstaden commented Apr 14, 2025

Release 1.4.3 for:
- Electra fork upgrade: The Ethereum Electra upgrade is going live on mainnet on 7 May. The Snowbridge Ethereum client needs to be upgraded before then. The change can be viewed in paritytech/polkadot-sdk#7075.

This release only includes BridgeHubPolkadot, since the required change is only related to this system parachain.

Closes: #654

@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Apr 14, 2025

@claravanstaden Could you please update the description to include a bit more context and note that we're only releasing BridgeHubPolkadot? Plus update desc with: Closes: https://github.com/polkadot-fellows/runtimes/issues/654

@anaelleltd @SBalaguer There's just one change related to dry-run (an additional parameter was added), which could potentially cause issues if anyone is using dry-run for BridgeHubPolkadot (unlikely) - if you need more info here for integration or whatever - @franciscoaguirre is the best person :).
This change technically affects all runtimes, but since we're currently only releasing BridgeHubPolkadot, we can merge it and then update CHANGELOG.md with more details in the upcoming 1.5.0 release.

@anaelleltd anaelleltd moved this from Todo to In Progress in Runtime releases Apr 15, 2025
@franciscoaguirre
Copy link
Copy Markdown
Contributor

The dry run functionality is a runtime API so the versioning system should already have us covered. It shouldn't be a breaking change

@claravanstaden claravanstaden marked this pull request as ready for review April 15, 2025 07:48
@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented Apr 15, 2025

@bkchr @ggwpez can we release only Polkadot-BH runtime? or on merging this PR automation will attempt to release everything?

e.g. the CI currently complains that all other runtimes haven't bumped spec version

It's also fine to do patch release for all runtimes, but most likely we will not upgrade the chains using these versions, but rather go directly to 1.5.0.

what do you think?

@franciscoaguirre
Copy link
Copy Markdown
Contributor

The dry run functionality is a runtime API so the versioning system should already have us covered. It shouldn't be a breaking change

Hmm, it seems like it is a breaking change. Both Rust code wanting to access the API and frontend clients will default to using the latest version. This means they'll have to change their code.

@franciscoaguirre
Copy link
Copy Markdown
Contributor

@SBalaguer @anaelleltd The breaking change is for anyone calling the DryRunApi on Bridge Hub they'll now need to either lower the runtime API version they are targeting or add a new parameter that specifies what XCM version they want it to return.

This is highly unlikely since Bridge Hub is mostly an implementation detail at this point and dry running something there doesn't offer much in return (we don't support dry-running the P<>K bridge yet for example).

@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Apr 15, 2025

can we release only Polkadot-BH runtime? or on merging this PR automation will attempt to release everything?

We just delete the unnecessary runtimes and edit the release message, it works fine.
Im not sure if the red CI can cause issues for the release pipeline, so maybe still patch bump all other other ones - even when we end up not using it.

@nkpar
Copy link
Copy Markdown
Contributor

nkpar commented Apr 15, 2025

We also need to update Kusama AH and Polkadot AH versions as part of it

@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Apr 15, 2025

We also need to update Kusama AH and Polkadot AH versions as part of it

Do you also need to release and enact them live as part of 1.4.3 or just change spec_version?

@acatangiu
Copy link
Copy Markdown
Contributor

so maybe still patch bump all other other ones - even when we end up not using it

@claravanstaden can you please bump all runtimes?

@nkpar
Copy link
Copy Markdown
Contributor

nkpar commented Apr 15, 2025

Do you also need to release and enact them live as part of 1.4.3 or just change spec_version?

Yes please, I need #668 to finish migration

@acatangiu
Copy link
Copy Markdown
Contributor

Do you also need to release and enact them live as part of 1.4.3 or just change spec_version?

Yes please, I need #668 to finish migration

You can get this with Release v1.5.0 #662 upgrade too, no?

The plan is to only upgrade Polkadot BH to this patch release because of urgency, while all other runtimes can wait 1-2 extra weeks and go straight to 1.5.0.

@nkpar
Copy link
Copy Markdown
Contributor

nkpar commented Apr 15, 2025

can wait 1-2 extra weeks

Because runtime is upgraded to newer version and waiting for state tried migration, warp sync is not working and it slows down other people work a bit. The change I introduced is small and only about migration controller.
If possible I would love to have it released sooner rather than later if no objections.

@claravanstaden
Copy link
Copy Markdown
Contributor Author

@claravanstaden can you please bump all runtimes?

@acatangiu added in 914b594.

Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could still have a CHANGELOG entry for #668, but dont want to hold this up.

@claravanstaden
Copy link
Copy Markdown
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot Bot merged commit f6cd32d into polkadot-fellows:main Apr 16, 2025
65 of 67 checks passed
@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@github-project-automation github-project-automation Bot moved this from In Progress to Done in Runtime releases Apr 16, 2025
@claravanstaden claravanstaden deleted the release-1-4-3 branch April 16, 2025 08:18
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Apr 16, 2025

We just delete the unnecessary runtimes and edit the release message, it works fine.

@ggwpez the runtimes are released, https://github.com/polkadot-fellows/runtimes/releases/tag/v1.4.3, can you please remove those which we won't need?

So far we need only Polkadot BridgeHub.

@nkpar sorry, I am not sure if I get your comment, so do we need/want to upgrade/enact also Polkadot/Kusama AssetHub from this 1.4.3 release? Basti made some comment here about testing: #668 (comment).
Please, confirm that if need or not PAH / KAH from release 1.4.3 to upgrade/enact?

@claravanstaden Are you going to prepare preimage call for referenda or who?

@nkpar
Copy link
Copy Markdown
Contributor

nkpar commented Apr 16, 2025

confirm that if need or not PAH / KAH from release 1.4.3 to upgrade/enact

Yes please, we need to upgrade PAH, KAH to finish state trie migration

@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Apr 16, 2025

confirm that if need or not PAH / KAH from release 1.4.3 to upgrade/enact

Yes please, we need to upgrade PAH, KAH to finish state trie migration

We just delete the unnecessary runtimes and edit the release message, it works fine.

@ggwpez the runtimes are released, https://github.com/polkadot-fellows/runtimes/releases/tag/v1.4.3, can you please remove those which we won't need?

@claravanstaden Are you going to prepare preimage call for referenda or who?

so the final list for upgrade:

  • bridge-hub-polkadot-runtime
  • asset-hub-kusama-runtime
  • asset-hub-polkadot-runtime

@claravanstaden
Copy link
Copy Markdown
Contributor Author

@bkontur sure, I'll do the preimage.

@claravanstaden
Copy link
Copy Markdown
Contributor Author

I am not seeing the Asset Hub Polkadot wasm in the release: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.4.3

@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented Apr 16, 2025

I am not seeing the Asset Hub Polkadot wasm in the release: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.4.3

@ggwpez @bkchr https://github.com/polkadot-fellows/runtimes/actions/runs/14487936234
some runtimes were not built and published, e.g. PAH: https://github.com/polkadot-fellows/runtimes/actions/runs/14487936234/job/40637567546 because of docker issue:

Cannot connect to the Docker daemon at unix:///run/user/1001/docker.sock. Is the docker daemon running?

I am not sure, how to retrigger this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Release 1.4.3

8 participants