Repository navigation
Replace inline SVG icons with Lucide - #49
Merged
Merged
Conversation
Swap Wally's hand-embedded inline <svg> icons (58 total: 47 static in HTML + 11 dynamic in JS) for Lucide, self-hosting the pinned v1.43.0 UMD bundle in web/js/vendors/ to match the repo's local-vendor convention (no CDN). Add a 6-line web/js/icons.js helper exposing renderIcons(root) that calls lucide.createIcons, with a DOMContentLoaded auto-render for static placeholders. Load both scripts deferred in index.html, transactions.html, and settings.html (login.html has no app icons and is untouched). Dynamic icons in ag-grid cellRenderers and innerHTML injections (transactions grid actions/recurring badge, settings currency list + empty state, API keys list + empty state, recurring grid actions/badge) now insert <i data-lucide> placeholders and call renderIcons(el) after injection, so icons survive ag-grid re-renders and list refreshes. Consolidate near-duplicate glyphs (two trash variants, two plus styles) into single Lucide names. Existing CSS that sizes/colors icons via descendant svg selectors (.cashflow-icon svg, .grid-action-btn svg, .search-icon, etc.) keeps working since Lucide emits <svg class="lucide">; standalone icons carry their original width/height and colors flow via currentColor. Bootstrap component glyphs (navbar-toggler-icon, btn-close, spinner-border) are left untouched as they are integrated into Bootstrap components. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the inline SVG icons with Lucide icons rendered via
lucide.createIcons:<i data-lucide="...">placeholders are rendered onDOMContentLoadedrenderIcons(root)is exposed injs/icons.jsfor icons injected dynamically (ag-grid cells, innerHTML) — call it right after inserting markupTesting
Built locally with Docker and verified in the browser: dashboard, transactions, and settings pages render the new icons correctly.