Repository navigation
Fix recurring transactions dropping months on edit - #48
Merged
Merged
Conversation
Bug A: editing endDate/frequency updated the template but never regenerated the transactions, so months past the original end date were silently missing. update_transactions_from_recurring now deletes the affected range and regenerates from the template. Bug B: monthly/yearly occurrences drifted to lower days (31st stuck on 28th after February) because dates were accumulated. Advance from the start anchor (start + n periods) to re-anchor the original day each iteration. Bug C: make the future/past boundary strictly greater-than today consistently so a transaction dated today is never overwritten. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in recurring transaction handling:
endDate/frequencyupdated the template but never regenerated transactions, so months past the original end date were silently missing.update_transactions_from_recurringnow deletes the affected range and regenerates from the template.Testing
Verified the router functions against an in-memory DB:
allmode rebuilds everything