Skip to content

fix: bump extendr and libR-sys to remove non-api calls warnings on R 4.5.0#1339

Merged
etiennebacher merged 2 commits into
pola-rs:mainfrom
eitsupi:bump-libr-sys
Mar 15, 2025
Merged

fix: bump extendr and libR-sys to remove non-api calls warnings on R 4.5.0#1339
etiennebacher merged 2 commits into
pola-rs:mainfrom
eitsupi:bump-libr-sys

Conversation

@eitsupi

@eitsupi eitsupi commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

Related to #1105

Since the new release of extendr contained some breaking changes that cannot be applied here (#1154, #1164, #1187), I cherry-picked only the relevant commits in the fork (rpolars/extendr#5).

Before:

* checking compiled code ... WARNING
Warning: File ‘polars/libs/polars.so’:
  Found non-API calls to R: ‘BODY’, ‘CLOENV’, ‘DATAPTR’, ‘ENCLOS’,
    ‘ENVFLAGS’, ‘FORMALS’, ‘FRAME’, ‘HASHTAB’, ‘PRCODE’, ‘PRENV’,
    ‘PRSEEN’, ‘PRVALUE’, ‘Rf_allocSExp’, ‘Rf_findVarInFrame3’,
    ‘SET_BODY’, ‘SET_CLOENV’, ‘SET_ENCLOS’, ‘SET_ENVFLAGS’,
    ‘SET_FORMALS’, ‘SET_PRCODE’, ‘SET_PRENV’, ‘SET_PRVALUE’,
    ‘STRING_PTR’, ‘SYMVALUE’, ‘XLENGTH_EX’
These entry points may be removed soon:
‘PRSEEN’, ‘SYMVALUE’

This PR:

* checking compiled code ... NOTE
File ‘polars/libs/polars.so’:
  Found non-API calls to R: ‘BODY’, ‘CLOENV’, ‘DATAPTR’, ‘ENCLOS’,
    ‘FORMALS’

My goal is to keep this package alive on the R-multiverse Production repository1 after the R 4.5 release. (since I don't expect the next branch to replace this package in another month, related to #1336)

Footnotes

  1. https://r-multiverse.org/production.html#quality

@eitsupi

eitsupi commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator Author

The WARNINGS seem to disappear with this change ( the current CI is probably too strict, as it does not turn green just because there is a NOTE)

@eitsupi eitsupi marked this pull request as ready for review March 13, 2025 16:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the dependency versions to remove non-API calls by updating the package version and revising the extendr API dependency.

  • Version bumped from 0.45.0 to 0.45.1.
  • extendr-api dependency updated to point to a fork with the required commits.

@eitsupi eitsupi changed the title fix: bump libR-sys to remove non-api calls fix: bump extendr/libR-sys to remove non-api calls Mar 13, 2025
@eitsupi eitsupi changed the title fix: bump extendr/libR-sys to remove non-api calls fix: bump extendr and libR-sys to remove non-api calls Mar 13, 2025
@eitsupi eitsupi changed the title fix: bump extendr and libR-sys to remove non-api calls fix: bump extendr and libR-sys to remove non-api calls warnings Mar 13, 2025
@eitsupi eitsupi requested a review from Copilot March 13, 2025 23:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the package version and updates the extendr dependency to remove non-api calls warnings while maintaining support for the current production environment.

  • Bumped the package version from 0.45.0 to 0.45.1.
  • Updated the extendr-api dependency to point to the rpolars fork with a new commit revision.
Comments suppressed due to low confidence (1)

src/rust/Cargo.toml:39

  • The dependency now points to a fork of extendr. Please verify that the selected commit in this fork provides all the necessary fixes and compatibility for production use.
extendr-api = { git = "https://github.com/rpolars/extendr", rev = "53bc326c5cdb4ac8684219d283d0ad21450072c1", default-features = false, features = [

@eitsupi eitsupi changed the title fix: bump extendr and libR-sys to remove non-api calls warnings fix: bump extendr and libR-sys to remove non-api calls warnings on R 4.5.0 Mar 13, 2025
@etiennebacher

Copy link
Copy Markdown
Collaborator

LGTM, thanks I didn't think it would be that simple

@eitsupi

eitsupi commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator Author

Thank you.
I was disappointed that I couldn't delete the all NOTEs, but I gave up because I saw that the NOTE was also displayed in other extendr-based packages.

Anyway, I think this will support R 4.5.0.

@etiennebacher etiennebacher merged commit 70ac7e9 into pola-rs:main Mar 15, 2025
@eitsupi eitsupi deleted the bump-libr-sys branch March 15, 2025 22:20
eitsupi added a commit to eitsupi/r-polars that referenced this pull request Mar 18, 2025
@eitsupi eitsupi mentioned this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants