Skip to content

Add transaction reconciliation foundation - #15

Merged
nakasyou merged 8 commits into
mainfrom
agent/add-reconciliation-foundation
Jul 16, 2026
Merged

nakasyou merged 8 commits into
mainfrom
agent/add-reconciliation-foundation

Conversation

@nakasyou

Copy link
Copy Markdown
Member

Summary

  • Persist provider observations and revisions, including stable Mobile Suica identity alignment.
  • Add financial accounts, economic events, postings, bindings, account links, and queued reconciliation jobs.
  • Add deterministic debit-funded wallet-top-up proposals plus review and account-link UI.
  • Normalize Mobile Suica connector IDs and add the reconcile OAuth scope.

Validation

  • bun fmt
  • bun typecheck
  • bun run test
  • Live Mobile Suica SDK history invocation succeeded (no recent transactions returned).
  • SMBC Direct live verification remains blocked by a disconnected session requiring two-factor authentication.

Follow-up scope

  • Provider-boundary raw payload capture and credit-card statement, refund, and fee matchers remain follow-up work.

@nakasyou
nakasyou marked this pull request as ready for review July 14, 2026 13:51
Copilot AI review requested due to automatic review settings July 14, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

codecov-commenter commented Jul 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.66393% with 109 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/mnie-server/src/reconciliation.ts 84.51% 6 Missing and 31 partials ⚠️
apps/mnie-server/src/history.ts 11.11% 23 Missing and 1 partial ⚠️
apps/mnie-server/src/rpc/workspace.ts 0.00% 17 Missing ⚠️
apps/mnie-server/src/observations.ts 93.07% 1 Missing and 8 partials ⚠️
apps/mnie-server/src/providers/registry.ts 0.00% 6 Missing ⚠️
apps/mnie-server/src/cron/index.ts 33.33% 4 Missing ⚠️
apps/mnie-server/src/rpc/handler.ts 55.55% 2 Missing and 2 partials ⚠️
apps/mnie-server/src/db/index.ts 89.65% 2 Missing and 1 partial ⚠️
packages/provider-mobile-suica/src/index.ts 40.00% 3 Missing ⚠️
apps/mnie-server/src/rpc/admin.ts 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
apps/mnie-server/src/app.ts 95.65% <ø> (ø)
apps/mnie-server/src/db/schema.ts 100.00% <100.00%> (+17.64%) ⬆️
apps/mnie-server/src/routes/oauth.ts 21.95% <100.00%> (ø)
apps/mnie-server/src/security/oauth-provider.ts 12.28% <100.00%> (ø)
packages/provider-paypay-sec/src/provider.ts 58.75% <ø> (+0.41%) ⬆️
packages/provider-sbi-sec/src/provider.ts 36.02% <ø> (-0.34%) ⬇️
apps/mnie-server/src/rpc/admin.ts 4.46% <0.00%> (ø)
apps/mnie-server/src/db/index.ts 79.74% <89.65%> (ø)
packages/provider-mobile-suica/src/index.ts 14.19% <40.00%> (ø)
apps/mnie-server/src/cron/index.ts 25.30% <33.33%> (ø)
... and 6 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nakasyou

Copy link
Copy Markdown
Member Author

@codex review

@nakasyou

Copy link
Copy Markdown
Member Author

@yutakobayashidev review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bac67c11b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/mnie-server/src/app.ts Resolved
Comment thread apps/mnie-server/src/reconciliation.ts Resolved
Comment thread apps/mnie-server/src/cron/index.ts Resolved
Comment thread apps/mnie-server/src/observations.ts Resolved
@nakasyou
nakasyou merged commit d1544c7 into main Jul 16, 2026
2 checks passed
@nakasyou
nakasyou deleted the agent/add-reconciliation-foundation branch July 16, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants