wip: building block context#3308
Closed
dai-shi wants to merge 3 commits intobreaking/building-blocks-in-paramsfrom
Closed
wip: building block context#3308dai-shi wants to merge 3 commits intobreaking/building-blocks-in-paramsfrom
dai-shi wants to merge 3 commits intobreaking/building-blocks-in-paramsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: +16 B (+0.02%) Total Size: 104 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/4TSWS9FUV |
See documentations for usage instructions.
…ing-blocks-in-params-2
dmaskasky
reviewed
Apr 21, 2026
| @@ -63,6 +66,8 @@ const createContinuablePromise = <T>( | |||
| getValue: () => PromiseLike<T> | T, | |||
| ) => { | |||
| const buildingBlocks = INTERNAL_getBuildingBlocks(store) | |||
Collaborator
There was a problem hiding this comment.
Neat idea with the s prop.
Should we do INTERNAL_getBuildingBlocksContext instead?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.