Skip to content

refactor(internals): iterative unmountAtom (scale)#3282

Open
dmaskasky wants to merge 2 commits intopmndrs:mainfrom
dmaskasky:iterative-unmount-experiment
Open

refactor(internals): iterative unmountAtom (scale)#3282
dmaskasky wants to merge 2 commits intopmndrs:mainfrom
dmaskasky:iterative-unmount-experiment

Conversation

@dmaskasky
Copy link
Copy Markdown
Collaborator

@dmaskasky dmaskasky commented Mar 30, 2026

Summary

Refactors unmountAtom to use an iterative solution.

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
jotai Ready Ready Preview, Comment Apr 1, 2026 9:20pm

Request Review

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Mar 30, 2026 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 30, 2026 •
edited
Loading

More templates

npm i https://pkg.pr.new/jotai@3282

commit: 3d0bad4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026 •
edited
Loading

LiveCodes Preview in LiveCodes

Latest commit: 3d0bad4
Last updated: Apr 1, 2026 9:20pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/59VB5L3PP

See documentations for usage instructions.

@dmaskasky dmaskasky changed the title Iterative unmount experiment iterative unmountAtom Mar 30, 2026
@dmaskasky dmaskasky force-pushed the iterative-unmount-experiment branch from 0eef53c to 39d0c18 Compare April 1, 2026 18:06
dai-shi
dai-shi reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for this too? #3281 (review)

dai-shi
dai-shi reviewed Apr 2, 2026
View reviewed changes
Comment thread src/vanilla/internals.ts
@dai-shi dai-shi added this to the v2.19.1 milestone Apr 2, 2026
@dmaskasky
Copy link
Copy Markdown
Collaborator Author

dmaskasky commented Apr 3, 2026

And for this too? #3281 (review)

This one is harder. I am currently blocked by #3294.

@dmaskasky dmaskasky changed the title iterative unmountAtom refactor(internals): iterative unmountAtom (scale) Apr 3, 2026
@dai-shi
Copy link
Copy Markdown
Member

dai-shi commented Apr 3, 2026

should we merge this without tests?

@dmaskasky
Copy link
Copy Markdown
Collaborator Author

dmaskasky commented Apr 3, 2026

No, I would like some help understanding #3294 first.

@dai-shi dai-shi modified the milestones: v2.19.1, v2.20.0 Apr 7, 2026
@dai-shi
Copy link
Copy Markdown
Member

dai-shi commented May 5, 2026

No, I would like some help understanding #3294 first.

@dmaskasky Is this ready for merge?

@dmaskasky
Copy link
Copy Markdown
Collaborator Author

dmaskasky commented May 6, 2026 •
edited
Loading

@dmaskasky Is this ready for merge?

Yes.

@dai-shi dai-shi modified the milestones: v2.20.0, v2.20.1 May 6, 2026
@dmaskasky
Copy link
Copy Markdown
Collaborator Author

dmaskasky commented May 6, 2026

@copilot resolve the merge conflicts in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-shi dai-shi dai-shi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.20.1

Development

Successfully merging this pull request may close these issues.

2 participants

@dmaskasky @dai-shi