Port code to use ext-encoding#244
Open
dktapps wants to merge 11 commits into
Open
Conversation
this is a test run to see what it's like to work with the new API. So far, it seems to be OK, although I keep forgetting the parameters for the static methods, which is annoying. Instinctively I'm reaching for instance methods, and I have to keep reminding myself why I chose to implement the new API this way instead of using instance methods (it's because this design is more resistant to mistakes).
|
Is this completed? |
im curious too |
Member
Author
|
It seemed fine during integration testing, but I haven't touched it for a while. Will probably integrate it with the PM 5.40 release if all goes well. The rollout plan was to get BedrockProtocol live with it first so that if any weird problems showed up with ext-encoding, they'd be relatively easy to debug. That actually went much better than I expected, seems basically no one even noticed the change aside from a jump in performance, although that also led to me forgetting about it. So it's looking good for migrating other components too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a test run to see what it's like to work with the new API.
So far, it seems to be OK, although I keep forgetting the parameters for the static methods, which is annoying. Instinctively I'm reaching for instance methods, and I have to keep reminding myself why I chose to implement the new API this way instead of using instance methods (it's because this design is more resistant to mistakes).
Haven't tested this yet. Fine to ignore the test errors (it's just because the extension isn't present).