First look at ext-encoding integration#122
Closed
dktapps wants to merge 12 commits into
Closed
Conversation
in very brief tests, this yielded significant performance improvements, on the order of 2x for encoding and 1.5x for decoding.
Member
Author
|
Since this change would anyway cause some disruption downstream, I think it's time to take the opportunity to redesign the serializer API. A new API could coexist with the legacy API, avoiding BC breaks for the remainder of PM5. |
github-project-automation
Bot
moved this from In Progress
to Done
in ext-encoding integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in very brief tests, this yielded significant performance improvements, on the order of 2x for encoding and 1.5x for decoding.
This doesn't change any public API, but inheritors of
BaseNbtSerializerwill need to be updated to use this. In practice nothing exceptNetworkNbtSerializerin BedrockProtocol should be affected.