NOTICKET: Replace cutoff-dates with auto-validations on new topics - #869
Closed
aman-minz wants to merge 18 commits into
Closed
NOTICKET: Replace cutoff-dates with auto-validations on new topics#869aman-minz wants to merge 18 commits into
aman-minz wants to merge 18 commits into
Conversation
Revert rbac and Mykola's tests (temporary)
Revert BACK rbac and Mykola's tests
) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Fix compilation issue and update tests * Add more tests * Add more tests * Remove unused import * Revert TopicDeletionProgramSpec as the methods call across modules fails * ADAPT-1566: add retries for getVersion and getAllVersions from schema… (#849) * ADAPT-1566: add retries for getVersion and getAllVersions from schema registry * ADAPT-1148: added msk rbac (#845) * ADAPT-1148: added msk rbac * ADAPT-1148: make msk arn env var as optional (#850) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Add more tests * Incorporate review comments * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add more tests * Add test for InstantUtils and refactor * ADAPT-1570 Need a mechanism to validate logical types (#851) * ADAPT-1570 Need a mechanism to validate logical types * ADAPT-1570 Need a mechanism to validate logical types *added tests for comosite keys --------- Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com> * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add test for InstantUtils and refactor * Incorporate review comments * Refactored and removed unwanted variables and methods * Store default loophole cutoff date in a variable * Fix failing unit test * Remove InstantUtils.scala * Update default loophole cut-off date --------- Co-authored-by: Abhishek <abhishek-verma@pluralsight.com> Co-authored-by: Iryna Biletska <93545362+irynabiletskaps@users.noreply.github.com> Co-authored-by: mnikulesko <96866310+mnikulesko@users.noreply.github.com> Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com>
…t types of validations
aman-minz
requested review from
RenjithSomasekharan,
abhivermaaa,
irynabiletskaps,
mnikulesko,
shreedhar-kc and
znickle24
August 18, 2023 15:40
… patterns in new fields always
…s-instead-of-cutoff-date
As system such as snowflake which replicate data from DVS do not support the map datatype yet.
Contributor
Author
|
Closed this as it was on top of other feature branch. Open new PR 871 on top of master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix default loophole and timestamp-mills validations on new topics we had introduced cutoff-date. This PR gets rid of those in favour of new validations only on new topics.
This PR is branched out from PR 861. Diff of the contents for this PR can be seen here.