Feature/gradle implementation#309
Open
jimmyliang-gov wants to merge 105 commits into
Open
Conversation
…at-CSS/ploigos-step-runner into feature/gradle-support
Consume latest update from Ploigos
* feat: Gradle PSR support --------- Co-authored-by: Christopher Mason <cmason@redhat.com> Co-authored-by: Jimmy Liang <jimmy.liang_sc@sparksoftcorp.com> Co-authored-by: MJDP <aleem.malik@sparksoftcorp.com>
* feat: Gradle PSR support --------- Co-authored-by: Christopher Mason <cmason@redhat.com> Co-authored-by: Nicholas Siviglia <nicholas.siviglia_sc@sparksoftcorp.com> Co-authored-by: Jimmy Liang <jimmy.liang_sc@sparksoftcorp.com> Co-authored-by: Jay Pithadia <jay.pithadia@sparksoftcorp.com> Co-authored-by: Syed Ajaz Hussain <syedajaz.hussain@cms.hhs.gov> Co-authored-by: MJDP <aleem.malik@sparksoftcorp.com>
Contributor
|
@jimmyliang-gov this still in progress or ready to review (though it looks like some CI issues to fix first) |
Contributor
|
@jimmyliang-gov still working on this? |
Author
|
Yes we are. I should have an update very soon.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Ian Tewksbury ***@***.***>
Sent: Friday, January 17, 2025 8:26:26 AM
To: ploigos/ploigos-step-runner ***@***.***>
Cc: Jimmy Liang - C ***@***.***>; Mention ***@***.***>
Subject: Re: [ploigos/ploigos-step-runner] Feature/gradle implementation (PR #309)
Security Notice: This email is from an EXTERNAL source. Do not click links or attachments unless you recognize the sender and know the content is safe.
@jimmyliang-gov<https://github.com/jimmyliang-gov> still working on this?
—
Reply to this email directly, view it on GitHub<#309 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BI2ZVT5GKADTF2ULUCNFXA32LEVLFAVCNFSM6AAAAABU7JQ5TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYG4ZDMMZRHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
|
@itewk - Linting fixed. Let me know if you'd like to discuss on this. |
Contributor
@jimmyliang-gov looks like still some issues. can you resolve those and start collapsing down your commits? doesnt have to be all one commit if there are some logical breaks...just not 105 please ;) |
Author
|
@itewk can you add @aleemmalik-gov as a member? |
Contributor
|
@jimmyliang-gov done. fyi you need except the invite @aleemmalik-gov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement step runners to implement the Gradle build tool. This is used for apps that are built and deployed with Gradle as opposed to Maven.
Breaking?
No
However - the Gradle image needs to be merged as well to have the Gradle PSR work.
Integration Testing
Built and deployed on a local devsecops Jenkins pipeline.